From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIl8H-0007hE-PM for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:54:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIl8G-0007Jp-Jn for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:54:21 -0400 Received: from hall.aurel32.net ([88.191.126.93]:47993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIl8G-0007J8-DS for qemu-devel@nongnu.org; Mon, 01 Oct 2012 14:54:20 -0400 From: Aurelien Jarno Date: Mon, 1 Oct 2012 20:54:13 +0200 Message-Id: <1349117653-19380-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v2] target-xtensa: de-optimize EXTUI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Max Filippov , Aurelien Jarno Now that "and" with 0xff, 0xffff and 0xffffffff and "shr" with 0 shift are optimized in tcg/tcg-op.h there is no need to do it in target-xtensa/translate.c. Cc: Max Filippov Signed-off-by: Aurelien Jarno --- target-xtensa/translate.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) v1 -> v2: also remove the test on shiftimm to select either a shift or a move. diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index b9acd70..82e8ccc 100644 --- a/target-xtensa/translate.c +++ b/target-xtensa/translate.c @@ -1829,26 +1829,8 @@ static void disas_xtensa_insn(DisasContext *dc) int maskimm = (1 << (OP2 + 1)) - 1; TCGv_i32 tmp = tcg_temp_new_i32(); - - if (shiftimm) { - tcg_gen_shri_i32(tmp, cpu_R[RRR_T], shiftimm); - } else { - tcg_gen_mov_i32(tmp, cpu_R[RRR_T]); - } - - switch (maskimm) { - case 0xff: - tcg_gen_ext8u_i32(cpu_R[RRR_R], tmp); - break; - - case 0xffff: - tcg_gen_ext16u_i32(cpu_R[RRR_R], tmp); - break; - - default: - tcg_gen_andi_i32(cpu_R[RRR_R], tmp, maskimm); - break; - } + tcg_gen_shri_i32(tmp, cpu_R[RRR_T], shiftimm); + tcg_gen_andi_i32(cpu_R[RRR_R], tmp, maskimm); tcg_temp_free(tmp); } break; -- 1.7.10.4