From: Alex Williamson <alex.williamson@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alex Barcelo <abarcelo@ac.upc.edu>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
Date: Tue, 02 Oct 2012 08:37:05 -0600 [thread overview]
Message-ID: <1349188625.28860.314.camel@bling.home> (raw)
In-Reply-To: <506A8591.9040306@redhat.com>
On Tue, 2012-10-02 at 08:11 +0200, Paolo Bonzini wrote:
> Il 01/10/2012 20:49, Alex Williamson ha scritto:
> >> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
> >> > struct vfio_iommu_type1_dma_map map = {
> >> > .argsz = sizeof(map),
> >> > .flags = VFIO_DMA_MAP_FLAG_READ,
> >> > - .vaddr = (__u64)vaddr,
> >> > + .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?
With a simple test program, I don't seem to get sign extension either
way. Logically uintptr_t seems preferable to me. I'll add a patch to
my tree. Thanks,
Alex
next prev parent reply other threads:[~2012-10-02 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 18:41 [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems Anthony Liguori
2012-10-01 18:49 ` Alex Williamson
2012-10-02 6:11 ` Paolo Bonzini
2012-10-02 14:37 ` Alex Williamson [this message]
2012-10-02 15:03 ` Anthony Liguori
2012-10-01 19:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349188625.28860.314.camel@bling.home \
--to=alex.williamson@redhat.com \
--cc=abarcelo@ac.upc.edu \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).