From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1TJ3b8-00042K-5J
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 10:37:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1TJ3ay-0001AV-7Q
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 10:37:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51330)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1TJ3ax-0001A8-V8
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 10:37:12 -0400
Message-ID: <1349188625.28860.314.camel@bling.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Tue, 02 Oct 2012 08:37:05 -0600
In-Reply-To: <506A8591.9040306@redhat.com>
References: <1349116911-18550-1-git-send-email-aliguori@us.ibm.com>
	<1349117389.28860.299.camel@bling.home> <506A8591.9040306@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Alex Barcelo <abarcelo@ac.upc.edu>, qemu-devel@nongnu.org

On Tue, 2012-10-02 at 08:11 +0200, Paolo Bonzini wrote:
> Il 01/10/2012 20:49, Alex Williamson ha scritto:
> >> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
> >> >      struct vfio_iommu_type1_dma_map map = {
> >> >          .argsz = sizeof(map),
> >> >          .flags = VFIO_DMA_MAP_FLAG_READ,
> >> > -        .vaddr = (__u64)vaddr,
> >> > +        .vaddr = (__u64)(intptr_t)vaddr,
> 
> Does this need to be uintptr_t?

With a simple test program, I don't seem to get sign extension either
way.  Logically uintptr_t seems preferable to me.  I'll add a patch to
my tree.  Thanks,

Alex