From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJOzx-0004A4-UI for qemu-devel@nongnu.org; Wed, 03 Oct 2012 09:28:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJOzr-0006Zm-Sk for qemu-devel@nongnu.org; Wed, 03 Oct 2012 09:28:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJOzr-0006ZI-LU for qemu-devel@nongnu.org; Wed, 03 Oct 2012 09:28:19 -0400 From: Eduardo Habkost Date: Wed, 3 Oct 2012 10:28:58 -0300 Message-Id: <1349270954-4657-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1349270954-4657-1-git-send-email-ehabkost@redhat.com> References: <1349270954-4657-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC 02/18] pc: create PC object on pc_init1() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Gleb Natapov , Paolo Bonzini It would be interesting to make the generic machine intialization code create a machine object instead, but changing the machine initialization function signature is a nightmare, so by now I am creating the object inside pc_init1(). The object is not used for anything by now, but it will be used during some steps of the initialization, later. Signed-off-by: Eduardo Habkost --- hw/pc_piix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index fd5898f..28b5f8a 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -148,6 +148,7 @@ static void pc_init1(MemoryRegion *system_memory, MemoryRegion *pci_memory; MemoryRegion *rom_memory; void *fw_cfg = NULL; + PC *pc = PC(object_new(TYPE_PC_MACHINE)); pc_cpus_init(cpu_model); @@ -285,6 +286,8 @@ static void pc_init1(MemoryRegion *system_memory, if (pci_enabled) { pc_pci_device_init(pci_bus); } + + qdev_init_nofail(DEVICE(pc)); } static void pc_init_pci(ram_addr_t ram_size, -- 1.7.11.4