From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Gleb Natapov" <gleb@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [RFC 04/18] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h)
Date: Wed, 3 Oct 2012 10:29:00 -0300 [thread overview]
Message-ID: <1349270954-4657-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1349270954-4657-1-git-send-email-ehabkost@redhat.com>
This will help reduce the qemu-common.h dependency hell.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
qemu-common.h | 57 ++--------------------------------------------
qemu-stdio.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 75 insertions(+), 55 deletions(-)
create mode 100644 qemu-stdio.h
diff --git a/qemu-common.h b/qemu-common.h
index 15d9e4e..ed7ee81 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -6,6 +6,8 @@
#include "compiler.h"
#include "config-host.h"
+#include "qemu-stdio.h"
+
#if defined(__arm__) || defined(__sparc__) || defined(__mips__) || defined(__hppa__) || defined(__ia64__)
#define WORDS_ALIGNED
#endif
@@ -48,28 +50,6 @@ typedef struct MigrationParams MigrationParams;
#include "qemu-os-posix.h"
#endif
-#ifndef O_LARGEFILE
-#define O_LARGEFILE 0
-#endif
-#ifndef O_BINARY
-#define O_BINARY 0
-#endif
-#ifndef MAP_ANONYMOUS
-#define MAP_ANONYMOUS MAP_ANON
-#endif
-#ifndef ENOMEDIUM
-#define ENOMEDIUM ENODEV
-#endif
-#if !defined(ENOTSUP)
-#define ENOTSUP 4096
-#endif
-#if !defined(ECANCELED)
-#define ECANCELED 4097
-#endif
-#ifndef TIME_MAX
-#define TIME_MAX LONG_MAX
-#endif
-
/* HOST_LONG_BITS is the size of a native pointer in bits. */
#if UINTPTR_MAX == UINT32_MAX
# define HOST_LONG_BITS 32
@@ -79,39 +59,6 @@ typedef struct MigrationParams MigrationParams;
# error Unknown pointer size
#endif
-#ifndef CONFIG_IOVEC
-#define CONFIG_IOVEC
-struct iovec {
- void *iov_base;
- size_t iov_len;
-};
-/*
- * Use the same value as Linux for now.
- */
-#define IOV_MAX 1024
-#else
-#include <sys/uio.h>
-#endif
-
-typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
- GCC_FMT_ATTR(2, 3);
-
-#ifdef _WIN32
-#define fsync _commit
-#if !defined(lseek)
-# define lseek _lseeki64
-#endif
-int qemu_ftruncate64(int, int64_t);
-#if !defined(ftruncate)
-# define ftruncate qemu_ftruncate64
-#endif
-
-static inline char *realpath(const char *path, char *resolved_path)
-{
- _fullpath(resolved_path, path, _MAX_PATH);
- return resolved_path;
-}
-#endif
/* icount */
void configure_icount(const char *option);
diff --git a/qemu-stdio.h b/qemu-stdio.h
new file mode 100644
index 0000000..73d9f91
--- /dev/null
+++ b/qemu-stdio.h
@@ -0,0 +1,73 @@
+/* Some basic definitions related to stdio.h or other I/O interfaces
+ */
+#ifndef QEMU_STDIO_H
+#define QEMU_STDIO_H
+
+#include "compiler.h"
+#include "config-host.h"
+
+#include <stdlib.h>
+#include <stdio.h>
+#include <fcntl.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+#include <sys/mman.h>
+
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
+#ifndef O_BINARY
+#define O_BINARY 0
+#endif
+#ifndef MAP_ANONYMOUS
+#define MAP_ANONYMOUS MAP_ANON
+#endif
+#ifndef ENOMEDIUM
+#define ENOMEDIUM ENODEV
+#endif
+#if !defined(ENOTSUP)
+#define ENOTSUP 4096
+#endif
+#if !defined(ECANCELED)
+#define ECANCELED 4097
+#endif
+#ifndef TIME_MAX
+#define TIME_MAX LONG_MAX
+#endif
+
+#ifndef CONFIG_IOVEC
+#define CONFIG_IOVEC
+struct iovec {
+ void *iov_base;
+ size_t iov_len;
+};
+/*
+ * Use the same value as Linux for now.
+ */
+#define IOV_MAX 1024
+#else
+#include <sys/uio.h>
+#endif
+
+typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
+ GCC_FMT_ATTR(2, 3);
+
+#ifdef _WIN32
+#define fsync _commit
+#if !defined(lseek)
+# define lseek _lseeki64
+#endif
+int qemu_ftruncate64(int, int64_t);
+#if !defined(ftruncate)
+# define ftruncate qemu_ftruncate64
+#endif
+
+static inline char *realpath(const char *path, char *resolved_path)
+{
+ _fullpath(resolved_path, path, _MAX_PATH);
+ return resolved_path;
+}
+#endif
+
+#endif /* QEMU_STDIO_H */
--
1.7.11.4
next prev parent reply other threads:[~2012-10-03 13:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 13:28 [Qemu-devel] [RFC v2 00/18] Fix APIC-ID-based CPU topology Eduardo Habkost
2012-10-03 13:28 ` [Qemu-devel] [RFC 01/18] pc: create "PC" device class Eduardo Habkost
2012-10-03 14:38 ` Paolo Bonzini
2012-10-03 14:48 ` Eduardo Habkost
2012-10-03 14:50 ` Paolo Bonzini
2012-10-04 13:46 ` Anthony Liguori
2012-10-04 13:50 ` Paolo Bonzini
2012-10-04 14:28 ` Anthony Liguori
2012-10-04 14:43 ` Eduardo Habkost
2012-10-04 15:10 ` Anthony Liguori
2012-10-04 16:03 ` Eduardo Habkost
2012-10-04 17:42 ` Anthony Liguori
2012-10-04 17:51 ` Eduardo Habkost
2012-10-04 16:00 ` Andreas Färber
2012-10-04 13:57 ` Eduardo Habkost
2012-10-04 14:29 ` Anthony Liguori
2012-10-04 15:57 ` Eduardo Habkost
2012-10-04 17:43 ` Anthony Liguori
2012-10-03 13:28 ` [Qemu-devel] [RFC 02/18] pc: create PC object on pc_init1() Eduardo Habkost
2012-10-03 14:40 ` Paolo Bonzini
2012-10-03 14:53 ` Eduardo Habkost
2012-10-03 14:54 ` Paolo Bonzini
2012-10-03 13:28 ` [Qemu-devel] [RFC 03/18] pc: add PC object argument to some init functions Eduardo Habkost
2012-10-04 11:56 ` Igor Mammedov
2012-10-03 13:29 ` Eduardo Habkost [this message]
2012-10-03 13:29 ` [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h Eduardo Habkost
2012-10-04 12:00 ` Igor Mammedov
2012-10-04 13:14 ` Eduardo Habkost
2012-10-04 14:05 ` Igor Mammedov
2012-10-03 13:29 ` [Qemu-devel] [RFC 06/18] hw/apic.c: rename bit functions to not conflict with bitops.h (v2) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 07/18] kvm: create kvm_arch_vcpu_id() function Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 08/18] target-i386: kvm: set vcpu_id to APIC ID instead of CPU index (v2) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 09/18] target-i386: cpu: move cpuid_apic_id initialization to cpu_x86_register() Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 10/18] target-i386: cpu: add apic_id argument " Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 11/18] target-i386: cpu_x86_init: allow APIC ID to be set by caller Eduardo Habkost
2012-10-04 12:47 ` Igor Mammedov
2012-10-03 13:29 ` [Qemu-devel] [RFC 12/18] fw_cfg: remove FW_CFG_MAX_CPUS from fw_cfg_init() Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 13/18] pc: set explicit APIC ID for CPUs Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 14/18] pc: create apic_id_for_cpu() function (v3) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 15/18] pc: set fw_cfg data based on APIC ID calculation (v2) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 16/18] tests: support target-specific unit tests Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 17/18] target-i386: topology & APIC ID utility functions (v2) Eduardo Habkost
2012-10-03 20:11 ` Blue Swirl
2012-10-03 13:29 ` [Qemu-devel] [RFC 18/18] pc: generate APIC IDs according to CPU topology (v3) Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349270954-4657-5-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).