From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJPjQ-0007JJ-VE for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:15:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJPjH-00089f-EQ for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:15:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJPjH-000890-65 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:15:15 -0400 From: Avi Kivity Date: Wed, 3 Oct 2012 16:15:08 +0200 Message-Id: <1349273708-29482-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH] s390: avoid reaching into memory core internals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org use cpu_physical_memory_is_io() instead. Signed-off-by: Avi Kivity --- target-s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c index e9b3cae..2da4c90 100644 --- a/target-s390x/misc_helper.c +++ b/target-s390x/misc_helper.c @@ -81,7 +81,7 @@ int sclp_service_call(CPUS390XState *env, uint32_t sccb, uint64_t code) #endif /* basic checks */ - if (!memory_region_is_ram(phys_page_find(sccb >> TARGET_PAGE_BITS)->mr)) { + if (cpu_physical_memory_is_io(sccb)) { return -PGM_ADDRESSING; } if (sccb & ~0x7ffffff8ul) { -- 1.7.12