From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJSfq-000718-Eh for qemu-devel@nongnu.org; Wed, 03 Oct 2012 13:23:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJSfp-0005PX-Cf for qemu-devel@nongnu.org; Wed, 03 Oct 2012 13:23:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJSfp-0005PK-4n for qemu-devel@nongnu.org; Wed, 03 Oct 2012 13:23:53 -0400 From: Luiz Capitulino Date: Wed, 3 Oct 2012 14:24:19 -0300 Message-Id: <1349285059-5415-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1349285059-5415-1-git-send-email-lcapitulino@redhat.com> References: <1349285059-5415-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth@linux.vnet.ibm.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Has the side effect of changing the default directory used to save the freeze status file from /tmp to /var/run. This is a beneficial change for two reasons: 1. FHS states that programs must not assume that files in /tmp will still exist between invocations of the program. This defeats the purpose of the freeze status file 2. FHS dictates that /var/run should be cleaned on boot, this automatically cleans up any stale file Signed-off-by: Luiz Capitulino --- qemu-ga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index b747470..cbfd021 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -40,8 +40,8 @@ #else #define QGA_VIRTIO_PATH_DEFAULT "\\\\.\\Global\\org.qemu.guest_agent.0" #endif -#define QGA_PIDFILE_DEFAULT "/var/run/qemu-ga.pid" -#define QGA_STATEDIR_DEFAULT "/tmp" +#define QGA_PIDFILE_DEFAULT CONFIG_QEMUGA_STATEDIR "/qemu-ga.pid" +#define QGA_STATEDIR_DEFAULT CONFIG_QEMUGA_STATEDIR #define QGA_SENTINEL_BYTE 0xFF struct GAState { -- 1.7.12.315.g682ce8b