From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH 0/6] qdev: handle global properties after all instance_init calls
Date: Wed, 3 Oct 2012 14:48:32 -0300 [thread overview]
Message-ID: <1349286518-28123-1-git-send-email-ehabkost@redhat.com> (raw)
Summary:
- Object properties are registered by the classes' instance_init()
functions
- qdev_prop_set_globals() needs all properties to be registered before being
called.
- Hence, qdev_prop_set_globals() can't be called from device_initfn().
Reference:
http://article.gmane.org/gmane.comp.emulators.qemu/173753
This series is a larger than the single-patch suggestion sent by Igor (URL
above), just because I wanted to include a unit test for the new code. To do
that, I pulled the qdev-split code sent previously to the list, so a qdev unit
test could be written without pulling too many dependencies.
Patches 1-3 are just code movement, patch 3 adds the qdev unit test, patches 5-6
finally introduce post_init(), and move the qdev_prop_set_globals() call to
post_init().
Anthony Liguori (1):
qdev: split up header so it can be used in cpu.h
Eduardo Habkost (4):
qdev: separate core from the code used only by qemu-system-*
tests: unit tests for qdev global-properties handling
qom: introduce post_init() function
qdev: set globals on post_init() function
Igor Mammedov (1):
qapi-types.h doesn't really need to include qemu-common.h
hw/Makefile.objs | 1 +
hw/irq.h | 2 +
hw/mc146818rtc.c | 1 +
hw/qdev-addr.c | 1 +
hw/qdev-core.h | 240 ++++++++++++++++++++++++++
hw/qdev-monitor.h | 16 ++
hw/qdev-properties-system.c | 329 ++++++++++++++++++++++++++++++++++++
hw/qdev-properties.c | 321 +----------------------------------
hw/qdev-properties.h | 131 +++++++++++++++
hw/qdev-system.c | 93 +++++++++++
hw/qdev.c | 102 +----------
hw/qdev.h | 371 +----------------------------------------
include/qemu/object.h | 3 +
qom/object.c | 14 ++
scripts/qapi-types.py | 3 +-
tests/Makefile | 6 +
tests/fake-qdev.c | 52 ++++++
tests/test-qdev-global-props.c | 178 ++++++++++++++++++++
18 files changed, 1083 insertions(+), 781 deletions(-)
create mode 100644 hw/qdev-core.h
create mode 100644 hw/qdev-monitor.h
create mode 100644 hw/qdev-properties-system.c
create mode 100644 hw/qdev-properties.h
create mode 100644 hw/qdev-system.c
create mode 100644 tests/fake-qdev.c
create mode 100644 tests/test-qdev-global-props.c
--
1.7.11.4
next reply other threads:[~2012-10-03 17:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 17:48 Eduardo Habkost [this message]
2012-10-03 17:48 ` [Qemu-devel] [PATCH 1/6] qdev: split up header so it can be used in cpu.h Eduardo Habkost
2012-10-03 17:48 ` [Qemu-devel] [PATCH 2/6] qapi-types.h doesn't really need to include qemu-common.h Eduardo Habkost
2012-10-03 17:48 ` [Qemu-devel] [PATCH 3/6] qdev: separate core from the code used only by qemu-system-* Eduardo Habkost
2012-10-03 17:48 ` [Qemu-devel] [PATCH 4/6] tests: unit tests for qdev global-properties handling Eduardo Habkost
2012-10-03 17:48 ` [Qemu-devel] [PATCH 5/6] qom: introduce post_init() function Eduardo Habkost
2012-10-03 17:48 ` [Qemu-devel] [PATCH 6/6] qdev: set globals on " Eduardo Habkost
2013-07-09 14:32 ` [Qemu-devel] [PATCH 0/6] qdev: handle global properties after all instance_init calls Andreas Färber
2013-07-10 20:08 ` [Qemu-devel] [RFC 0/3 v2] " Eduardo Habkost
2013-07-10 20:08 ` [Qemu-devel] [RFC 1/3 v2] tests: unit tests for qdev global-properties handling Eduardo Habkost
2013-07-10 20:08 ` [Qemu-devel] [RFC 2/3 v2] qom: introduce post_init() function Eduardo Habkost
2013-07-11 6:29 ` Igor Mammedov
2013-07-12 0:29 ` Eduardo Habkost
2013-07-10 20:08 ` [Qemu-devel] [RFC 3/3 v2] qdev: set globals on " Eduardo Habkost
2013-07-11 6:48 ` Igor Mammedov
2013-07-12 14:57 ` Eduardo Habkost
2013-07-28 19:44 ` [Qemu-devel] [RFC 0/3 v2] qdev: handle global properties after all instance_init calls Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349286518-28123-1-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).