From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJWbP-0001ZI-Od for qemu-devel@nongnu.org; Wed, 03 Oct 2012 17:35:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJWbO-00081z-IJ for qemu-devel@nongnu.org; Wed, 03 Oct 2012 17:35:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJWbO-00081U-9w for qemu-devel@nongnu.org; Wed, 03 Oct 2012 17:35:34 -0400 From: Luiz Capitulino Date: Wed, 3 Oct 2012 18:35:58 -0300 Message-Id: <1349300158-19113-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1349300158-19113-1-git-send-email-lcapitulino@redhat.com> References: <1349300158-19113-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] qemu-ga: use state dir from CONFIG_QEMU_LOCALSTATEDIR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth@linux.vnet.ibm.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Has the side effect of changing the default directory used to save the freeze status file from /tmp to ${prefix}/var/run. This is a beneficial change for two reasons: 1. FHS states that programs must not assume that files in /tmp will still exist between invocations of the program. This defeats the purpose of the freeze status file 2. FHS dictates that /var/run must be cleaned on boot, this ensures that a stale freeze status file will be removed on boot Signed-off-by: Luiz Capitulino --- qemu-ga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index b747470..daeaea5 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -40,8 +40,8 @@ #else #define QGA_VIRTIO_PATH_DEFAULT "\\\\.\\Global\\org.qemu.guest_agent.0" #endif -#define QGA_PIDFILE_DEFAULT "/var/run/qemu-ga.pid" -#define QGA_STATEDIR_DEFAULT "/tmp" +#define QGA_STATEDIR_DEFAULT CONFIG_QEMU_LOCALSTATEDIR "/run" +#define QGA_PIDFILE_DEFAULT QGA_STATEDIR_DEFAULT "/qemu-ga.pid" #define QGA_SENTINEL_BYTE 0xFF struct GAState { -- 1.7.12.315.g682ce8b