From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJrKp-0003tg-3H for qemu-devel@nongnu.org; Thu, 04 Oct 2012 15:43:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJrKo-0007hU-2A for qemu-devel@nongnu.org; Thu, 04 Oct 2012 15:43:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJnbs-0004HQ-Fz for qemu-devel@nongnu.org; Thu, 04 Oct 2012 11:45:13 -0400 Message-ID: <1349365507.2759.44.camel@ul30vt.home> From: Alex Williamson Date: Thu, 04 Oct 2012 09:45:07 -0600 In-Reply-To: <1349280245-16341-11-git-send-email-avi@redhat.com> References: <1349280245-16341-1-git-send-email-avi@redhat.com> <1349280245-16341-11-git-send-email-avi@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v1 10/22] vfio: use new MEMORY_LISTENER_DEFAULT_OPS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, liu ping fan , Blue Swirl , Anthony Liguori , Paolo Bonzini On Wed, 2012-10-03 at 18:03 +0200, Avi Kivity wrote: > Removes quite a bit of useless code. > > Signed-off-by: Avi Kivity > --- > hw/vfio_pci.c | 30 +----------------------------- > 1 file changed, 1 insertion(+), 29 deletions(-) > > diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c > index a1eeced..8e49535 100644 > --- a/hw/vfio_pci.c > +++ b/hw/vfio_pci.c > @@ -803,25 +803,6 @@ static int vfio_dma_unmap(VFIOContainer *container, > return 0; > } > > -static void vfio_listener_dummy1(MemoryListener *listener) > -{ > - /* We don't do batching (begin/commit) or care about logging */ > -} > - > -static void vfio_listener_dummy2(MemoryListener *listener, > - MemoryRegionSection *section) > -{ > - /* We don't do logging or care about nops */ > -} > - > -static void vfio_listener_dummy3(MemoryListener *listener, > - MemoryRegionSection *section, > - bool match_data, uint64_t data, > - EventNotifier *e) > -{ > - /* We don't care about eventfds */ > -} > - > static bool vfio_listener_skipped_section(MemoryRegionSection *section) > { > return !memory_region_is_ram(section->mr); > @@ -913,18 +894,9 @@ static void vfio_listener_region_del(MemoryListener *listener, > } > > static MemoryListener vfio_memory_listener = { > - .begin = vfio_listener_dummy1, > - .commit = vfio_listener_dummy1, > + MEMORY_LISTENER_DEFAULT_OPS, > .region_add = vfio_listener_region_add, > .region_del = vfio_listener_region_del, > - .region_nop = vfio_listener_dummy2, > - .log_start = vfio_listener_dummy2, > - .log_stop = vfio_listener_dummy2, > - .log_sync = vfio_listener_dummy2, > - .log_global_start = vfio_listener_dummy1, > - .log_global_stop = vfio_listener_dummy1, > - .eventfd_add = vfio_listener_dummy3, > - .eventfd_del = vfio_listener_dummy3, > }; > > static void vfio_listener_release(VFIOContainer *container) I'm happy to see this cleanup. Thanks Acked-by: Alex Williamson