From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK8Sm-0006j7-G3 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:01:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK8Sf-0006TP-Sk for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:01:12 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:44818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK8Sf-0006HH-Ld for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:01:05 -0400 Received: by mail-bk0-f45.google.com with SMTP id jf3so815270bkc.4 for ; Fri, 05 Oct 2012 07:01:05 -0700 (PDT) From: Stefan Hajnoczi Date: Fri, 5 Oct 2012 16:00:30 +0200 Message-Id: <1349445632-23674-11-git-send-email-stefanha@gmail.com> In-Reply-To: <1349445632-23674-1-git-send-email-stefanha@gmail.com> References: <1349445632-23674-1-git-send-email-stefanha@gmail.com> Subject: [Qemu-devel] [PATCH 10/12] qemu-barrier: Fix compiler version check for future gcc versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi From: Stefan Weil The current check will give a wrong result for gcc-5.x with x < 4. Using QEMU_GNUC_PREREQ is simpler and fixes that issue. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qemu-barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-barrier.h b/qemu-barrier.h index 7e11197..16f0942 100644 --- a/qemu-barrier.h +++ b/qemu-barrier.h @@ -19,7 +19,7 @@ * mfence on 32 bit as well, e.g. if built with -march=pentium-m. * However, on i386, there seem to be known bugs as recently as 4.3. * */ -#if defined(__GNUC__) && __GNUC__ >= 4 && __GNUC_MINOR__ >= 4 +#if QEMU_GNUC_PREREQ(4, 4) #define smp_mb() __sync_synchronize() #else #define smp_mb() asm volatile("lock; addl $0,0(%%esp) " ::: "memory") -- 1.7.11.4