From: Stefan Hajnoczi <stefanha@gmail.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [PATCH 02/12] configure: Support empty target list (--target-list=)
Date: Fri, 5 Oct 2012 16:00:22 +0200 [thread overview]
Message-ID: <1349445632-23674-3-git-send-email-stefanha@gmail.com> (raw)
In-Reply-To: <1349445632-23674-1-git-send-email-stefanha@gmail.com>
From: Stefan Weil <sw@weilnetz.de>
Specifying an empty target list with --target-list= is shorter
than specifying --disable-user --disable-system.
Both variants should give the same result: no targets at all.
This modification implements that feature.
It uses a trick which works with POSIX compliant shells to test whether
target_list is undefined (=> default targets) or empty (=> no targets).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
---
configure | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index e58846d..e51a793 100755
--- a/configure
+++ b/configure
@@ -125,7 +125,8 @@ cc_i386=i386-pc-linux-gnu-gcc
libs_qga=""
debug_info="yes"
-target_list=""
+# Don't accept a target_list environment variable.
+unset target_list
# Default value for a variable defining feature "foo".
# * foo="no" feature will only be used if --enable-foo arg is given
@@ -1288,7 +1289,7 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
exit 1
fi
-if test -z "$target_list" ; then
+if test -z "${target_list+xxx}" ; then
target_list="$default_target_list"
else
target_list=`echo "$target_list" | sed -e 's/,/ /g'`
--
1.7.11.4
next prev parent reply other threads:[~2012-10-05 14:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 14:00 [Qemu-devel] [PULL 00/12] Trivial patches for 24 September to 5 October 2012 Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 01/12] hw: Fix return value check for bdrv_read, bdrv_write Stefan Hajnoczi
2012-10-05 14:00 ` Stefan Hajnoczi [this message]
2012-10-05 14:00 ` [Qemu-devel] [PATCH 03/12] cpu: Add missing 'static' attribute to qemu_global_mutex Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 04/12] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 05/12] slirp: Fix spelling in comment (enought -> enough, insure -> ensure) Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 06/12] vnc: Fix spelling (hellmen -> hellman) in comment Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 07/12] qemu-sockets: Fix compiler warning (regression for MinGW) Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 08/12] cleanup useless return sentence Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 09/12] hw: Add missing 'static' attribute for QEMUMachine Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 10/12] qemu-barrier: Fix compiler version check for future gcc versions Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 11/12] qdev: kill bogus comment Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 12/12] versatilepb: Use symbolic indices for ARM PIC Stefan Hajnoczi
2012-10-06 18:35 ` [Qemu-devel] [PULL 00/12] Trivial patches for 24 September to 5 October 2012 Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349445632-23674-3-git-send-email-stefanha@gmail.com \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).