qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [PATCH 04/12] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code
Date: Fri,  5 Oct 2012 16:00:24 +0200	[thread overview]
Message-ID: <1349445632-23674-5-git-send-email-stefanha@gmail.com> (raw)
In-Reply-To: <1349445632-23674-1-git-send-email-stefanha@gmail.com>

From: Peter Maydell <peter.maydell@linaro.org>

Use the recently introduced tcg_out_mov_reg() function rather than
the equivalent inline code.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
---
 tcg/arm/tcg-target.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 2bad0a2..5e8dbdd 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -1197,20 +1197,11 @@ static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
     case 1:
     case 2:
     default:
-        if (data_reg != TCG_REG_R0) {
-            tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
-                            data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
-        }
+        tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
         break;
     case 3:
-        if (data_reg != TCG_REG_R0) {
-            tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
-                            data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0));
-        }
-        if (data_reg2 != TCG_REG_R1) {
-            tcg_out_dat_reg(s, COND_AL, ARITH_MOV,
-                            data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0));
-        }
+        tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0);
+        tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1);
         break;
     }
 
-- 
1.7.11.4

  parent reply	other threads:[~2012-10-05 14:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05 14:00 [Qemu-devel] [PULL 00/12] Trivial patches for 24 September to 5 October 2012 Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 01/12] hw: Fix return value check for bdrv_read, bdrv_write Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 02/12] configure: Support empty target list (--target-list=) Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 03/12] cpu: Add missing 'static' attribute to qemu_global_mutex Stefan Hajnoczi
2012-10-05 14:00 ` Stefan Hajnoczi [this message]
2012-10-05 14:00 ` [Qemu-devel] [PATCH 05/12] slirp: Fix spelling in comment (enought -> enough, insure -> ensure) Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 06/12] vnc: Fix spelling (hellmen -> hellman) in comment Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 07/12] qemu-sockets: Fix compiler warning (regression for MinGW) Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 08/12] cleanup useless return sentence Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 09/12] hw: Add missing 'static' attribute for QEMUMachine Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 10/12] qemu-barrier: Fix compiler version check for future gcc versions Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 11/12] qdev: kill bogus comment Stefan Hajnoczi
2012-10-05 14:00 ` [Qemu-devel] [PATCH 12/12] versatilepb: Use symbolic indices for ARM PIC Stefan Hajnoczi
2012-10-06 18:35 ` [Qemu-devel] [PULL 00/12] Trivial patches for 24 September to 5 October 2012 Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349445632-23674-5-git-send-email-stefanha@gmail.com \
    --to=stefanha@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).