From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKHjl-0006zs-5j for qemu-devel@nongnu.org; Fri, 05 Oct 2012 19:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKHjk-0003OC-0j for qemu-devel@nongnu.org; Fri, 05 Oct 2012 19:55:21 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:64287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKHjj-0003Jx-Qk for qemu-devel@nongnu.org; Fri, 05 Oct 2012 19:55:19 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so2357262pad.4 for ; Fri, 05 Oct 2012 16:55:19 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Fri, 5 Oct 2012 16:54:49 -0700 Message-Id: <1349481310-9237-3-git-send-email-rth@twiddle.net> In-Reply-To: <1349481310-9237-1-git-send-email-rth@twiddle.net> References: <1349481310-9237-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 02/23] target-sparc: Make CPU_LOG_INT useful by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl No need for ifdefs when the log mask does just as well. No need to print pc/npc when we're dumping the whole cpu state. Signed-off-by: Richard Henderson --- target-sparc/int32_helper.c | 7 ++----- target-sparc/int64_helper.c | 8 ++------ 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/target-sparc/int32_helper.c b/target-sparc/int32_helper.c index 5e33d50..9ac5aac 100644 --- a/target-sparc/int32_helper.c +++ b/target-sparc/int32_helper.c @@ -21,7 +21,7 @@ #include "trace.h" #include "sysemu.h" -//#define DEBUG_PCALL +#define DEBUG_PCALL #ifdef DEBUG_PCALL static const char * const excp_names[0x80] = { @@ -78,10 +78,7 @@ void do_interrupt(CPUSPARCState *env) } } - qemu_log("%6d: %s (v=%02x) pc=%08x npc=%08x SP=%08x\n", - count, name, intno, - env->pc, - env->npc, env->regwptr[6]); + qemu_log("%6d: %s (v=%02x)\n", count, name, intno); log_cpu_state(env, 0); #if 0 { diff --git a/target-sparc/int64_helper.c b/target-sparc/int64_helper.c index 5e3eff7..5d0bc6c 100644 --- a/target-sparc/int64_helper.c +++ b/target-sparc/int64_helper.c @@ -21,7 +21,7 @@ #include "helper.h" #include "trace.h" -//#define DEBUG_PCALL +#define DEBUG_PCALL #ifdef DEBUG_PCALL static const char * const excp_names[0x80] = { @@ -84,11 +84,7 @@ void do_interrupt(CPUSPARCState *env) } } - qemu_log("%6d: %s (v=%04x) pc=%016" PRIx64 " npc=%016" PRIx64 - " SP=%016" PRIx64 "\n", - count, name, intno, - env->pc, - env->npc, env->regwptr[6]); + qemu_log("%6d: %s (v=%04x)\n", count, name, intno); log_cpu_state(env, 0); #if 0 { -- 1.7.11.4