From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWi-0004PH-VK for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKTWg-0000Fz-SE for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:40 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:56060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKTWg-0000F2-LZ for qemu-devel@nongnu.org; Sat, 06 Oct 2012 08:30:38 -0400 Received: by mail-wg0-f53.google.com with SMTP id dr1so1675673wgb.10 for ; Sat, 06 Oct 2012 05:30:38 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Sat, 6 Oct 2012 14:30:16 +0200 Message-Id: <1349526621-13939-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ZF, SF and PF can always be computed from CC_DST except in the CC_OP_EFLAGS case (and CC_OP_DYNAMIC, which just resolves to CC_OP_EFLAGS in gen_compute_eflags). Use setcond to compute ZF and SF. We could also use a table lookup to compute PF. Signed-off-by: Paolo Bonzini --- target-i386/translate.c | 28 ++++++++++++++++++++++------ 1 file modificato, 22 inserzioni(+), 6 rimozioni(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 09512c3..daa36c1 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -859,9 +859,17 @@ static void gen_compute_eflags_p(DisasContext *s, TCGv reg) /* compute eflags.S to reg */ static void gen_compute_eflags_s(DisasContext *s, TCGv reg) { - gen_compute_eflags(s); - tcg_gen_shri_tl(reg, cpu_cc_src, 7); - tcg_gen_andi_tl(reg, reg, 1); + if (s->cc_op == CC_OP_DYNAMIC) { + gen_compute_eflags(s); + } + if (s->cc_op == CC_OP_EFLAGS) { + tcg_gen_shri_tl(reg, cpu_cc_src, 7); + tcg_gen_andi_tl(reg, reg, 1); + } else { + int size = (s->cc_op - CC_OP_ADDB) & 3; + gen_ext_tl(reg, cpu_cc_dst, size, true); + tcg_gen_setcondi_tl(TCG_COND_LT, reg, reg, 0); + } } /* compute eflags.O to reg */ @@ -875,9 +883,17 @@ static void gen_compute_eflags_o(DisasContext *s, TCGv reg) /* compute eflags.Z to reg */ static void gen_compute_eflags_z(DisasContext *s, TCGv reg) { - gen_compute_eflags(s); - tcg_gen_shri_tl(reg, cpu_cc_src, 6); - tcg_gen_andi_tl(reg, reg, 1); + if (s->cc_op == CC_OP_DYNAMIC) { + gen_compute_eflags(s); + } + if (s->cc_op == CC_OP_EFLAGS) { + tcg_gen_shri_tl(reg, cpu_cc_src, 6); + tcg_gen_andi_tl(reg, reg, 1); + } else { + int size = (s->cc_op - CC_OP_ADDB) & 3; + gen_ext_tl(reg, cpu_cc_dst, size, false); + tcg_gen_setcondi_tl(TCG_COND_EQ, reg, cpu_cc_dst, 0); + } } static inline void gen_setcc_slow_T0(DisasContext *s, int jcc_op) -- 1.7.12.1