From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
liu ping fan <qemulist@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH v1 18/23] s390: avoid reaching into memory core internals
Date: Sun, 7 Oct 2012 14:38:23 +0200 [thread overview]
Message-ID: <1349613508-22980-19-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1349613508-22980-1-git-send-email-avi@redhat.com>
use cpu_physical_memory_is_io() instead.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
target-s390x/misc_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
index e9b3cae..fdccd58 100644
--- a/target-s390x/misc_helper.c
+++ b/target-s390x/misc_helper.c
@@ -20,7 +20,6 @@
#include "cpu.h"
#include "memory.h"
-#include "cputlb.h"
#include "host-utils.h"
#include "helper.h"
#include <string.h>
@@ -81,7 +80,7 @@ int sclp_service_call(CPUS390XState *env, uint32_t sccb, uint64_t code)
#endif
/* basic checks */
- if (!memory_region_is_ram(phys_page_find(sccb >> TARGET_PAGE_BITS)->mr)) {
+ if (cpu_physical_memory_is_io(sccb)) {
return -PGM_ADDRESSING;
}
if (sccb & ~0x7ffffff8ul) {
--
1.7.12
next prev parent reply other threads:[~2012-10-07 12:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 12:38 [Qemu-devel] [PATCH v1 00/23] Integrate DMA into the memory API Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 01/23] memory: rename 'exec-obsolete.h' Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 02/23] vhost: use MemoryListener filtering to only monitor RAM address space Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 03/23] kvm: use separate MemoryListeners for memory and I/O Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 04/23] xen_pt: " Avi Kivity
2012-10-08 12:18 ` Stefano Stabellini
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 05/23] memory: prepare AddressSpace for exporting Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 06/23] memory: export AddressSpace Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 07/23] memory: maintain a list of address spaces Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 08/23] memory: provide defaults for MemoryListener operations Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 09/23] memory: use new MEMORY_LISTENER_DEFAULT_OPS Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 10/23] vfio: " Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 11/23] xen_pt: " Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 12/23] kvm: " Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 13/23] xen: " Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 14/23] memory: manage coalesced mmio via a MemoryListener Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 15/23] memory: move address_space_memory and address_space_io out of memory core Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 16/23] memory: move tcg flush into a tcg memory listener Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 17/23] memory: use AddressSpace for MemoryListener filtering Avi Kivity
2012-10-07 12:38 ` Avi Kivity [this message]
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 19/23] memory: per-AddressSpace dispatch Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 20/23] dma: make dma access its own address space Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 21/23] memory: add address_space_destroy() Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 22/23] pci: give each device its own address space Avi Kivity
2012-10-07 12:38 ` [Qemu-devel] [PATCH v1 23/23] pci: honor PCI_COMMAND_MASTER Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349613508-22980-19-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).