* [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc comparisons
@ 2012-10-08 15:42 Richard Henderson
2012-10-08 17:20 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2012-10-08 15:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl, Aurelien Jarno
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
target-sparc/translate.c | 1 +
1 file changed, 1 insertion(+)
This should fix the boot problem that Aurelien saw. It also showed
up in some userland speed testing I'm trying to set up (cross gcc).
r~
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 472eb51..71b9d65 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/translate.c
@@ -1120,6 +1120,7 @@ static void gen_compare(DisasCompare *cmp, bool xcc, unsigned int cond,
cmp->c2 = tcg_temp_new();
tcg_gen_ext32s_tl(cmp->c1, cpu_cc_src);
tcg_gen_ext32s_tl(cmp->c2, cpu_cc_src2);
+ break;
}
#endif
cmp->g1 = cmp->g2 = true;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc comparisons
2012-10-08 15:42 [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc comparisons Richard Henderson
@ 2012-10-08 17:20 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2012-10-08 17:20 UTC (permalink / raw)
To: Richard Henderson; +Cc: Blue Swirl, qemu-devel
On Mon, Oct 08, 2012 at 08:42:03AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> target-sparc/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> This should fix the boot problem that Aurelien saw. It also showed
> up in some userland speed testing I'm trying to set up (cross gcc).
>
>
I confirm it fixes the issue I reported.
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 472eb51..71b9d65 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -1120,6 +1120,7 @@ static void gen_compare(DisasCompare *cmp, bool xcc, unsigned int cond,
> cmp->c2 = tcg_temp_new();
> tcg_gen_ext32s_tl(cmp->c1, cpu_cc_src);
> tcg_gen_ext32s_tl(cmp->c2, cpu_cc_src2);
> + break;
> }
> #endif
> cmp->g1 = cmp->g2 = true;
> --
> 1.7.11.4
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-08 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-08 15:42 [Qemu-devel] [PATCH] target-sparc: Fix optimized %icc comparisons Richard Henderson
2012-10-08 17:20 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).