From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLbdg-0003oz-Ap for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:22:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLbda-0000zl-GV for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:22:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49826 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLbda-0000zB-AN for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:22:26 -0400 From: Tim Hardeck Date: Tue, 9 Oct 2012 17:21:40 +0200 Message-Id: <1349796101-6660-2-git-send-email-thardeck@suse.de> In-Reply-To: <1349796101-6660-1-git-send-email-thardeck@suse.de> References: <1349796101-6660-1-git-send-email-thardeck@suse.de> Subject: [Qemu-devel] [PATCH 1/2] vnc: fix segfault due to failed handshake List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Tim Hardeck , aliguori@us.ibm.com When the VNC server disconnects due to a failed handshake we don't have vs->bh allocated yet. Check for this case and don't delete it. Signed-off-by: Tim Hardeck --- ui/vnc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 01b2daf..656895a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1055,7 +1055,9 @@ static void vnc_disconnect_finish(VncState *vs) vnc_unlock_output(vs); qemu_mutex_destroy(&vs->output_mutex); - qemu_bh_delete(vs->bh); + if (vs->bh != NULL) { + qemu_bh_delete(vs->bh); + } buffer_free(&vs->jobs_buffer); for (i = 0; i < VNC_STAT_ROWS; ++i) { -- 1.7.10.4