qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
	liu ping fan <qemulist@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH v3 18/23] s390: avoid reaching into memory core internals
Date: Tue,  9 Oct 2012 18:32:43 +0200	[thread overview]
Message-ID: <1349800368-15228-19-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1349800368-15228-1-git-send-email-avi@redhat.com>

use cpu_physical_memory_is_io() instead.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 target-s390x/misc_helper.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
index e9b3cae..fdccd58 100644
--- a/target-s390x/misc_helper.c
+++ b/target-s390x/misc_helper.c
@@ -20,7 +20,6 @@
 
 #include "cpu.h"
 #include "memory.h"
-#include "cputlb.h"
 #include "host-utils.h"
 #include "helper.h"
 #include <string.h>
@@ -81,7 +80,7 @@ int sclp_service_call(CPUS390XState *env, uint32_t sccb, uint64_t code)
 #endif
 
     /* basic checks */
-    if (!memory_region_is_ram(phys_page_find(sccb >> TARGET_PAGE_BITS)->mr)) {
+    if (cpu_physical_memory_is_io(sccb)) {
         return -PGM_ADDRESSING;
     }
     if (sccb & ~0x7ffffff8ul) {
-- 
1.7.12

  parent reply	other threads:[~2012-10-09 16:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 16:32 [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 01/23] memory: rename 'exec-obsolete.h' Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 02/23] vhost: use MemoryListener filtering to only monitor RAM address space Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 03/23] kvm: use separate MemoryListeners for memory and I/O Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 04/23] xen_pt: " Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 05/23] memory: prepare AddressSpace for exporting Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 06/23] memory: export AddressSpace Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 07/23] memory: maintain a list of address spaces Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 08/23] memory: provide defaults for MemoryListener operations Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 09/23] memory: drop no-op MemoryListener callbacks Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 11/23] xen_pt: " Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 13/23] xen: " Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener Avi Kivity
2012-10-22 12:57   ` Peter Maydell
2012-10-22 13:00     ` Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 15/23] memory: move address_space_memory and address_space_io out of memory core Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 16/23] memory: move tcg flush into a tcg memory listener Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 17/23] memory: use AddressSpace for MemoryListener filtering Avi Kivity
2012-10-09 16:32 ` Avi Kivity [this message]
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 21/23] memory: add address_space_destroy() Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 22/23] pci: give each device its own address space Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER Avi Kivity
2012-10-11  3:38   ` liu ping fan
2012-10-11  8:34     ` Avi Kivity
2012-10-11  8:49       ` liu ping fan
2012-10-11  8:53         ` Avi Kivity
     [not found] ` <1349800368-15228-20-git-send-email-avi@redhat.com>
2012-10-11  3:38   ` [Qemu-devel] [PATCH v3 19/23] memory: per-AddressSpace dispatch liu ping fan
2012-10-11  8:31     ` Avi Kivity
2012-10-11  8:45       ` liu ping fan
2012-10-11  8:51         ` Avi Kivity
2012-10-11 21:01 ` [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API Anthony Liguori
2012-10-15 13:16   ` Avi Kivity
2012-10-22  9:35     ` Avi Kivity
2012-10-22 12:39       ` Peter Maydell
2012-10-22 19:46         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349800368-15228-19-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemulist@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).