From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
liu ping fan <qemulist@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH v3 08/23] memory: provide defaults for MemoryListener operations
Date: Tue, 9 Oct 2012 18:32:33 +0200 [thread overview]
Message-ID: <1349800368-15228-9-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1349800368-15228-1-git-send-email-avi@redhat.com>
Many listeners don't need to respond to all MemoryListener callbacks;
provide suitable no-op defaults instead.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
memory.c | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/memory.c b/memory.c
index b58b97c..269af3f 100644
--- a/memory.c
+++ b/memory.c
@@ -99,13 +99,17 @@ static bool memory_listener_match(MemoryListener *listener,
switch (_direction) { \
case Forward: \
QTAILQ_FOREACH(_listener, &memory_listeners, link) { \
- _listener->_callback(_listener, ##_args); \
+ if (_listener->_callback) { \
+ _listener->_callback(_listener, ##_args); \
+ } \
} \
break; \
case Reverse: \
QTAILQ_FOREACH_REVERSE(_listener, &memory_listeners, \
memory_listeners, link) { \
- _listener->_callback(_listener, ##_args); \
+ if (_listener->_callback) { \
+ _listener->_callback(_listener, ##_args); \
+ } \
} \
break; \
default: \
@@ -120,7 +124,8 @@ static bool memory_listener_match(MemoryListener *listener,
switch (_direction) { \
case Forward: \
QTAILQ_FOREACH(_listener, &memory_listeners, link) { \
- if (memory_listener_match(_listener, _section)) { \
+ if (_listener->_callback \
+ && memory_listener_match(_listener, _section)) { \
_listener->_callback(_listener, _section, ##_args); \
} \
} \
@@ -128,7 +133,8 @@ static bool memory_listener_match(MemoryListener *listener,
case Reverse: \
QTAILQ_FOREACH_REVERSE(_listener, &memory_listeners, \
memory_listeners, link) { \
- if (memory_listener_match(_listener, _section)) { \
+ if (_listener->_callback \
+ && memory_listener_match(_listener, _section)) { \
_listener->_callback(_listener, _section, ##_args); \
} \
} \
@@ -1470,8 +1476,11 @@ static void listener_add_address_space(MemoryListener *listener,
}
if (global_dirty_log) {
- listener->log_global_start(listener);
+ if (listener->log_global_start) {
+ listener->log_global_start(listener);
+ }
}
+
FOR_EACH_FLAT_RANGE(fr, as->current_map) {
MemoryRegionSection section = {
.mr = fr->mr,
@@ -1481,7 +1490,9 @@ static void listener_add_address_space(MemoryListener *listener,
.offset_within_address_space = int128_get64(fr->addr.start),
.readonly = fr->readonly,
};
- listener->region_add(listener, §ion);
+ if (listener->region_add) {
+ listener->region_add(listener, §ion);
+ }
}
}
--
1.7.12
next prev parent reply other threads:[~2012-10-09 16:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 16:32 [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 01/23] memory: rename 'exec-obsolete.h' Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 02/23] vhost: use MemoryListener filtering to only monitor RAM address space Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 03/23] kvm: use separate MemoryListeners for memory and I/O Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 04/23] xen_pt: " Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 05/23] memory: prepare AddressSpace for exporting Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 06/23] memory: export AddressSpace Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 07/23] memory: maintain a list of address spaces Avi Kivity
2012-10-09 16:32 ` Avi Kivity [this message]
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 09/23] memory: drop no-op MemoryListener callbacks Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 11/23] xen_pt: " Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 13/23] xen: " Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener Avi Kivity
2012-10-22 12:57 ` Peter Maydell
2012-10-22 13:00 ` Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 15/23] memory: move address_space_memory and address_space_io out of memory core Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 16/23] memory: move tcg flush into a tcg memory listener Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 17/23] memory: use AddressSpace for MemoryListener filtering Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 18/23] s390: avoid reaching into memory core internals Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 21/23] memory: add address_space_destroy() Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 22/23] pci: give each device its own address space Avi Kivity
2012-10-09 16:32 ` [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER Avi Kivity
2012-10-11 3:38 ` liu ping fan
2012-10-11 8:34 ` Avi Kivity
2012-10-11 8:49 ` liu ping fan
2012-10-11 8:53 ` Avi Kivity
[not found] ` <1349800368-15228-20-git-send-email-avi@redhat.com>
2012-10-11 3:38 ` [Qemu-devel] [PATCH v3 19/23] memory: per-AddressSpace dispatch liu ping fan
2012-10-11 8:31 ` Avi Kivity
2012-10-11 8:45 ` liu ping fan
2012-10-11 8:51 ` Avi Kivity
2012-10-11 21:01 ` [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API Anthony Liguori
2012-10-15 13:16 ` Avi Kivity
2012-10-22 9:35 ` Avi Kivity
2012-10-22 12:39 ` Peter Maydell
2012-10-22 19:46 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349800368-15228-9-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).