* [Qemu-devel] [PATCH v2] virtfs-proxy-helper: check return code of setfsgid/setfsuid
@ 2012-10-10 16:19 Paolo Bonzini
2012-10-10 16:24 ` Stefan Weil
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2012-10-10 16:19 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, sw
Fixes the following error with glibc 2.16 on Fedora 18:
virtfs-proxy-helper.c: In function ‘setfsugid’:
virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result]
virtfs-proxy-helper.c:294:13: error: ignoring return value of ‘setfsuid’, declared with attribute warn_unused_result [-Werror=unused-result]
cc1: all warnings being treated as errors
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
fsdev/virtfs-proxy-helper.c | 8 ++++++--
1 file modificato, 6 inserzioni(+), 2 rimozioni(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index f9a8270..9060743 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -290,8 +290,12 @@ static int setfsugid(int uid, int gid)
CAP_DAC_OVERRIDE,
};
- setfsgid(gid);
- setfsuid(uid);
+ if (setfsgid(gid) < 0) {
+ return -1;
+ }
+ if (setfsuid(uid) < 0) {
+ return -1;
+ }
if (uid != 0 || gid != 0) {
return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0);
--
1.7.12.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] virtfs-proxy-helper: check return code of setfsgid/setfsuid
2012-10-10 16:19 [Qemu-devel] [PATCH v2] virtfs-proxy-helper: check return code of setfsgid/setfsuid Paolo Bonzini
@ 2012-10-10 16:24 ` Stefan Weil
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2012-10-10 16:24 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
Am 10.10.2012 18:19, schrieb Paolo Bonzini:
> Fixes the following error with glibc 2.16 on Fedora 18:
>
> virtfs-proxy-helper.c: In function ‘setfsugid’:
> virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result]
> virtfs-proxy-helper.c:294:13: error: ignoring return value of ‘setfsuid’, declared with attribute warn_unused_result [-Werror=unused-result]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> fsdev/virtfs-proxy-helper.c | 8 ++++++--
> 1 file modificato, 6 inserzioni(+), 2 rimozioni(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index f9a8270..9060743 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -290,8 +290,12 @@ static int setfsugid(int uid, int gid)
> CAP_DAC_OVERRIDE,
> };
>
> - setfsgid(gid);
> - setfsuid(uid);
> + if (setfsgid(gid) < 0) {
> + return -1;
> + }
> + if (setfsuid(uid) < 0) {
> + return -1;
> + }
>
> if (uid != 0 || gid != 0) {
> return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0);
You are too fast for me :-)
Patch v3 is needed, see my other mail.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-10 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 16:19 [Qemu-devel] [PATCH v2] virtfs-proxy-helper: check return code of setfsgid/setfsuid Paolo Bonzini
2012-10-10 16:24 ` Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).