* [Qemu-devel] [PATCH] Add nvram to default boot device list
@ 2012-10-11 2:04 Avik Sil
2012-10-11 12:48 ` Alexander Graf
2012-10-11 22:59 ` David Gibson
0 siblings, 2 replies; 12+ messages in thread
From: Avik Sil @ 2012-10-11 2:04 UTC (permalink / raw)
To: dwg, agraf, qemu-ppc, qemu-devel; +Cc: nikunj
This patch adds nvram specified boot device into qemu default
boot_devices list. This helps firmware to boot from nvram specified
boot device if no -boot option is specified.
Suggested by: Alexander Graf <agraf@suse.de>
Signed-off-by: Avik Sil <aviksil@linux.vnet.ibm.com>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 48049ef..8adc40b 100644
--- a/vl.c
+++ b/vl.c
@@ -2349,7 +2349,7 @@ int main(int argc, char **argv, char **envp)
const char *icount_option = NULL;
const char *initrd_filename;
const char *kernel_filename, *kernel_cmdline;
- char boot_devices[33] = "cad"; /* default to HD->floppy->CD-ROM */
+ char boot_devices[33] = "xcad"; /* default to NVRAM->HD->floppy->CD-ROM */
DisplayState *ds;
DisplayChangeListener *dcl;
int cyls, heads, secs, translation;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-11 2:04 [Qemu-devel] [PATCH] Add nvram to default boot device list Avik Sil
@ 2012-10-11 12:48 ` Alexander Graf
2012-10-11 22:59 ` David Gibson
1 sibling, 0 replies; 12+ messages in thread
From: Alexander Graf @ 2012-10-11 12:48 UTC (permalink / raw)
To: Avik Sil; +Cc: qemu-ppc, qemu-devel, nikunj, dwg
On 11.10.2012, at 04:04, Avik Sil wrote:
> This patch adds nvram specified boot device into qemu default
> boot_devices list. This helps firmware to boot from nvram specified
> boot device if no -boot option is specified.
Did you check that no other user of the boot device list gets confused by this? Also, this new 'x' bit needs to be documented. Plus, we need a SLOF update to make use of it.
Alex
>
> Suggested by: Alexander Graf <agraf@suse.de>
>
> Signed-off-by: Avik Sil <aviksil@linux.vnet.ibm.com>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 48049ef..8adc40b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2349,7 +2349,7 @@ int main(int argc, char **argv, char **envp)
> const char *icount_option = NULL;
> const char *initrd_filename;
> const char *kernel_filename, *kernel_cmdline;
> - char boot_devices[33] = "cad"; /* default to HD->floppy->CD-ROM */
> + char boot_devices[33] = "xcad"; /* default to NVRAM->HD->floppy->CD-ROM */
> DisplayState *ds;
> DisplayChangeListener *dcl;
> int cyls, heads, secs, translation;
> --
> 1.7.11.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-11 2:04 [Qemu-devel] [PATCH] Add nvram to default boot device list Avik Sil
2012-10-11 12:48 ` Alexander Graf
@ 2012-10-11 22:59 ` David Gibson
2012-10-12 0:03 ` Alexander Graf
2012-10-12 7:12 ` Avik Sil
1 sibling, 2 replies; 12+ messages in thread
From: David Gibson @ 2012-10-11 22:59 UTC (permalink / raw)
To: Avik Sil; +Cc: qemu-ppc, agraf, nikunj, qemu-devel
On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
> This patch adds nvram specified boot device into qemu default
> boot_devices list. This helps firmware to boot from nvram specified
> boot device if no -boot option is specified.
I really don't think this is a good idea, it extends an already
deprecated mechanism in a fuzzy way and requires careful checking to
see if it could break anything. On all platforms the boot sequence
should be:
if bootindex is specified:
boot according to bootindex
else if -boot is specified:
boot according to -boot sequence
else:
use platform firmware default sequence
The last will of course vary by platform, and could depend on platform
details like the contents of NVRAM. Your original idea of making it
clear to the guest when -boot has been specified (as opposed to when
it contains its default value) was the right one, and this "x" in
-boot is going the wrong direction.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-11 22:59 ` David Gibson
@ 2012-10-12 0:03 ` Alexander Graf
2012-10-12 0:28 ` David Gibson
2012-10-16 3:44 ` Avik Sil
2012-10-12 7:12 ` Avik Sil
1 sibling, 2 replies; 12+ messages in thread
From: Alexander Graf @ 2012-10-12 0:03 UTC (permalink / raw)
To: David Gibson
Cc: Nikunj A Dadhania, Gleb Natapov, qemu-devel qemu-devel,
qemu-ppc List, Avik Sil, Anthony Liguori
On 12.10.2012, at 00:59, David Gibson wrote:
> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>> This patch adds nvram specified boot device into qemu default
>> boot_devices list. This helps firmware to boot from nvram specified
>> boot device if no -boot option is specified.
>
> I really don't think this is a good idea, it extends an already
> deprecated mechanism in a fuzzy way and requires careful checking to
> see if it could break anything. On all platforms the boot sequence
> should be:
> if bootindex is specified:
> boot according to bootindex
> else if -boot is specified:
> boot according to -boot sequence
> else:
> use platform firmware default sequence
>
> The last will of course vary by platform, and could depend on platform
> details like the contents of NVRAM. Your original idea of making it
> clear to the guest when -boot has been specified (as opposed to when
> it contains its default value) was the right one, and this "x" in
> -boot is going the wrong direction.
Given that this is a fundamental direction for a bunch of machines, how about we talk about it on the weekly QEMU call?
Alex
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-12 0:03 ` Alexander Graf
@ 2012-10-12 0:28 ` David Gibson
2012-10-12 0:29 ` Alexander Graf
2012-10-16 3:44 ` Avik Sil
1 sibling, 1 reply; 12+ messages in thread
From: David Gibson @ 2012-10-12 0:28 UTC (permalink / raw)
To: Alexander Graf
Cc: Nikunj A Dadhania, Gleb Natapov, qemu-devel qemu-devel,
qemu-ppc List, Avik Sil, Anthony Liguori
On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote:
>
> On 12.10.2012, at 00:59, David Gibson wrote:
>
> > On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
> >> This patch adds nvram specified boot device into qemu default
> >> boot_devices list. This helps firmware to boot from nvram specified
> >> boot device if no -boot option is specified.
> >
> > I really don't think this is a good idea, it extends an already
> > deprecated mechanism in a fuzzy way and requires careful checking to
> > see if it could break anything. On all platforms the boot sequence
> > should be:
> > if bootindex is specified:
> > boot according to bootindex
> > else if -boot is specified:
> > boot according to -boot sequence
> > else:
> > use platform firmware default sequence
> >
> > The last will of course vary by platform, and could depend on platform
> > details like the contents of NVRAM. Your original idea of making it
> > clear to the guest when -boot has been specified (as opposed to when
> > it contains its default value) was the right one, and this "x" in
> > -boot is going the wrong direction.
>
> Given that this is a fundamental direction for a bunch of machines,
> how about we talk about it on the weekly QEMU call?
Uh, is this a call I know about?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-12 0:28 ` David Gibson
@ 2012-10-12 0:29 ` Alexander Graf
2012-10-12 3:02 ` Chris Wright
0 siblings, 1 reply; 12+ messages in thread
From: Alexander Graf @ 2012-10-12 0:29 UTC (permalink / raw)
To: David Gibson
Cc: Chris Wright, Nikunj A Dadhania, Gleb Natapov, Juan Quintela,
qemu-devel qemu-devel, qemu-ppc List, Avik Sil, Anthony Liguori
On 12.10.2012, at 02:28, David Gibson wrote:
> On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote:
>>
>> On 12.10.2012, at 00:59, David Gibson wrote:
>>
>>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>>>> This patch adds nvram specified boot device into qemu default
>>>> boot_devices list. This helps firmware to boot from nvram specified
>>>> boot device if no -boot option is specified.
>>>
>>> I really don't think this is a good idea, it extends an already
>>> deprecated mechanism in a fuzzy way and requires careful checking to
>>> see if it could break anything. On all platforms the boot sequence
>>> should be:
>>> if bootindex is specified:
>>> boot according to bootindex
>>> else if -boot is specified:
>>> boot according to -boot sequence
>>> else:
>>> use platform firmware default sequence
>>>
>>> The last will of course vary by platform, and could depend on platform
>>> details like the contents of NVRAM. Your original idea of making it
>>> clear to the guest when -boot has been specified (as opposed to when
>>> it contains its default value) was the right one, and this "x" in
>>> -boot is going the wrong direction.
>>
>> Given that this is a fundamental direction for a bunch of machines,
>> how about we talk about it on the weekly QEMU call?
>
> Uh, is this a call I know about?
I would hope so. Chris / Juan, who is in charge of the phone numbers these days?
Alex
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-12 0:29 ` Alexander Graf
@ 2012-10-12 3:02 ` Chris Wright
2012-10-16 11:45 ` Avik Sil
0 siblings, 1 reply; 12+ messages in thread
From: Chris Wright @ 2012-10-12 3:02 UTC (permalink / raw)
To: Alexander Graf
Cc: Chris Wright, Gleb Natapov, Nikunj A Dadhania, Juan Quintela,
qemu-devel qemu-devel, David Gibson, qemu-ppc List, Avik Sil,
Anthony Liguori
* Alexander Graf (agraf@suse.de) wrote:
> On 12.10.2012, at 02:28, David Gibson wrote:
> > On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote:
> >> On 12.10.2012, at 00:59, David Gibson wrote:
> >>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
> >>>> This patch adds nvram specified boot device into qemu default
> >>>> boot_devices list. This helps firmware to boot from nvram specified
> >>>> boot device if no -boot option is specified.
> >>>
> >>> I really don't think this is a good idea, it extends an already
> >>> deprecated mechanism in a fuzzy way and requires careful checking to
> >>> see if it could break anything. On all platforms the boot sequence
> >>> should be:
> >>> if bootindex is specified:
> >>> boot according to bootindex
> >>> else if -boot is specified:
> >>> boot according to -boot sequence
> >>> else:
> >>> use platform firmware default sequence
> >>>
> >>> The last will of course vary by platform, and could depend on platform
> >>> details like the contents of NVRAM. Your original idea of making it
> >>> clear to the guest when -boot has been specified (as opposed to when
> >>> it contains its default value) was the right one, and this "x" in
> >>> -boot is going the wrong direction.
> >>
> >> Given that this is a fundamental direction for a bunch of machines,
> >> how about we talk about it on the weekly QEMU call?
> >
> > Uh, is this a call I know about?
>
> I would hope so. Chris / Juan, who is in charge of the phone numbers these days?
Added David to the invite which contains the call details (very
unfriendly time for .au I'm afraid, 14:00 UTC).
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-12 3:02 ` Chris Wright
@ 2012-10-16 11:45 ` Avik Sil
0 siblings, 0 replies; 12+ messages in thread
From: Avik Sil @ 2012-10-16 11:45 UTC (permalink / raw)
To: Chris Wright
Cc: Gleb Natapov, Nikunj A Dadhania, Juan Quintela,
qemu-devel qemu-devel, Alexander Graf, qemu-ppc List,
Anthony Liguori, David Gibson
On 10/12/2012 08:32 AM, Chris Wright wrote:
> * Alexander Graf (agraf@suse.de) wrote:
>> On 12.10.2012, at 02:28, David Gibson wrote:
>>> On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote:
>>>> On 12.10.2012, at 00:59, David Gibson wrote:
>>>>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>>>>>> This patch adds nvram specified boot device into qemu default
>>>>>> boot_devices list. This helps firmware to boot from nvram specified
>>>>>> boot device if no -boot option is specified.
>>>>>
>>>>> I really don't think this is a good idea, it extends an already
>>>>> deprecated mechanism in a fuzzy way and requires careful checking to
>>>>> see if it could break anything. On all platforms the boot sequence
>>>>> should be:
>>>>> if bootindex is specified:
>>>>> boot according to bootindex
>>>>> else if -boot is specified:
>>>>> boot according to -boot sequence
>>>>> else:
>>>>> use platform firmware default sequence
>>>>>
>>>>> The last will of course vary by platform, and could depend on platform
>>>>> details like the contents of NVRAM. Your original idea of making it
>>>>> clear to the guest when -boot has been specified (as opposed to when
>>>>> it contains its default value) was the right one, and this "x" in
>>>>> -boot is going the wrong direction.
>>>>
>>>> Given that this is a fundamental direction for a bunch of machines,
>>>> how about we talk about it on the weekly QEMU call?
>>>
>>> Uh, is this a call I know about?
>>
>> I would hope so. Chris / Juan, who is in charge of the phone numbers these days?
>
> Added David to the invite which contains the call details (very
> unfriendly time for .au I'm afraid, 14:00 UTC).
>
Is it OK if I proxy David as it's unfriendly time for him? Also can this
topic be included in today's call?
Regards,
Avik
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-12 0:03 ` Alexander Graf
2012-10-12 0:28 ` David Gibson
@ 2012-10-16 3:44 ` Avik Sil
2012-10-16 8:04 ` Alexander Graf
1 sibling, 1 reply; 12+ messages in thread
From: Avik Sil @ 2012-10-16 3:44 UTC (permalink / raw)
To: Alexander Graf
Cc: Nikunj A Dadhania, Gleb Natapov, qemu-devel qemu-devel,
David Gibson, qemu-ppc List, Anthony Liguori
On 10/12/2012 05:33 AM, Alexander Graf wrote:
>
> On 12.10.2012, at 00:59, David Gibson wrote:
>
>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>>> This patch adds nvram specified boot device into qemu default
>>> boot_devices list. This helps firmware to boot from nvram specified
>>> boot device if no -boot option is specified.
>>
>> I really don't think this is a good idea, it extends an already
>> deprecated mechanism in a fuzzy way and requires careful checking to
>> see if it could break anything. On all platforms the boot sequence
>> should be:
>> if bootindex is specified:
>> boot according to bootindex
>> else if -boot is specified:
>> boot according to -boot sequence
>> else:
>> use platform firmware default sequence
>>
>> The last will of course vary by platform, and could depend on platform
>> details like the contents of NVRAM. Your original idea of making it
>> clear to the guest when -boot has been specified (as opposed to when
>> it contains its default value) was the right one, and this "x" in
>> -boot is going the wrong direction.
>
> Given that this is a fundamental direction for a bunch of machines, how about we talk about it on the weekly QEMU call?
>
Was there any discussion on this in the last QEMU call?
Regards,
Avik
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-16 3:44 ` Avik Sil
@ 2012-10-16 8:04 ` Alexander Graf
2012-10-16 8:37 ` Andreas Färber
0 siblings, 1 reply; 12+ messages in thread
From: Alexander Graf @ 2012-10-16 8:04 UTC (permalink / raw)
To: Avik Sil
Cc: Nikunj A Dadhania, Gleb Natapov, qemu-devel qemu-devel,
David Gibson, qemu-ppc List, Anthony Liguori
On 16.10.2012, at 05:44, Avik Sil <aviksil@linux.vnet.ibm.com> wrote:
> On 10/12/2012 05:33 AM, Alexander Graf wrote:
>>
>> On 12.10.2012, at 00:59, David Gibson wrote:
>>
>>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>>>> This patch adds nvram specified boot device into qemu default
>>>> boot_devices list. This helps firmware to boot from nvram specified
>>>> boot device if no -boot option is specified.
>>>
>>> I really don't think this is a good idea, it extends an already
>>> deprecated mechanism in a fuzzy way and requires careful checking to
>>> see if it could break anything. On all platforms the boot sequence
>>> should be:
>>> if bootindex is specified:
>>> boot according to bootindex
>>> else if -boot is specified:
>>> boot according to -boot sequence
>>> else:
>>> use platform firmware default sequence
>>>
>>> The last will of course vary by platform, and could depend on platform
>>> details like the contents of NVRAM. Your original idea of making it
>>> clear to the guest when -boot has been specified (as opposed to when
>>> it contains its default value) was the right one, and this "x" in
>>> -boot is going the wrong direction.
>>
>> Given that this is a fundamental direction for a bunch of machines, how about we talk about it on the weekly QEMU call?
>>
> Was there any discussion on this in the last QEMU call?
The call is today :)
Alex
>
> Regards,
> Avik
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-16 8:04 ` Alexander Graf
@ 2012-10-16 8:37 ` Andreas Färber
0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2012-10-16 8:37 UTC (permalink / raw)
To: Alexander Graf
Cc: Nikunj A Dadhania, Gleb Natapov, qemu-devel qemu-devel,
David Gibson, qemu-ppc List, Avik Sil, Anthony Liguori
Am 16.10.2012 10:04, schrieb Alexander Graf:
>
>
> On 16.10.2012, at 05:44, Avik Sil <aviksil@linux.vnet.ibm.com> wrote:
>
>> On 10/12/2012 05:33 AM, Alexander Graf wrote:
>>>
>>> On 12.10.2012, at 00:59, David Gibson wrote:
>>>
>>>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>>>>> This patch adds nvram specified boot device into qemu default
>>>>> boot_devices list. This helps firmware to boot from nvram specified
>>>>> boot device if no -boot option is specified.
>>>>
>>>> I really don't think this is a good idea, it extends an already
>>>> deprecated mechanism in a fuzzy way and requires careful checking to
>>>> see if it could break anything. On all platforms the boot sequence
>>>> should be:
>>>> if bootindex is specified:
>>>> boot according to bootindex
>>>> else if -boot is specified:
>>>> boot according to -boot sequence
>>>> else:
>>>> use platform firmware default sequence
>>>>
>>>> The last will of course vary by platform, and could depend on platform
>>>> details like the contents of NVRAM. Your original idea of making it
>>>> clear to the guest when -boot has been specified (as opposed to when
>>>> it contains its default value) was the right one, and this "x" in
>>>> -boot is going the wrong direction.
>>>
>>> Given that this is a fundamental direction for a bunch of machines, how about we talk about it on the weekly QEMU call?
>>>
>> Was there any discussion on this in the last QEMU call?
>
> The call is today :)
...and the topic is not officially on the agenda yet. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
2012-10-11 22:59 ` David Gibson
2012-10-12 0:03 ` Alexander Graf
@ 2012-10-12 7:12 ` Avik Sil
1 sibling, 0 replies; 12+ messages in thread
From: Avik Sil @ 2012-10-12 7:12 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, agraf, nikunj, qemu-devel
On 10/12/2012 04:29 AM, David Gibson wrote:
> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>> This patch adds nvram specified boot device into qemu default
>> boot_devices list. This helps firmware to boot from nvram specified
>> boot device if no -boot option is specified.
>
> I really don't think this is a good idea, it extends an already
> deprecated mechanism in a fuzzy way and requires careful checking to
> see if it could break anything. On all platforms the boot sequence
> should be:
> if bootindex is specified:
> boot according to bootindex
> else if -boot is specified:
> boot according to -boot sequence
> else:
> use platform firmware default sequence
>
> The last will of course vary by platform, and could depend on platform
> details like the contents of NVRAM. Your original idea of making it
> clear to the guest when -boot has been specified (as opposed to when
> it contains its default value) was the right one, and this "x" in
> -boot is going the wrong direction.
>
I'm fine with the original approach. The patch is there in qemu-ppc m-l [1].
Regards,
Avik
[1] http://lists.nongnu.org/archive/html/qemu-ppc/2012-10/msg00081.html
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-10-16 11:45 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-11 2:04 [Qemu-devel] [PATCH] Add nvram to default boot device list Avik Sil
2012-10-11 12:48 ` Alexander Graf
2012-10-11 22:59 ` David Gibson
2012-10-12 0:03 ` Alexander Graf
2012-10-12 0:28 ` David Gibson
2012-10-12 0:29 ` Alexander Graf
2012-10-12 3:02 ` Chris Wright
2012-10-16 11:45 ` Avik Sil
2012-10-16 3:44 ` Avik Sil
2012-10-16 8:04 ` Alexander Graf
2012-10-16 8:37 ` Andreas Färber
2012-10-12 7:12 ` Avik Sil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).