qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 2/8] pseries: Clean up inconsistent variable name in xics.c
Date: Thu, 11 Oct 2012 21:47:38 +1000	[thread overview]
Message-ID: <1349956064-26709-3-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1349956064-26709-1-git-send-email-david@gibson.dropbear.id.au>

Throughout xics.c 'nr' is used to refer to a global interrupt number, and
'server' is used to refer to an interrupt server number (i.e. CPU number).
Except in icp_set_mfrr(), where 'nr' is used as a server number.  Fix this
confusing inconsistency.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/xics.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/xics.c b/hw/xics.c
index ce88aa7..7a899dd 100644
--- a/hw/xics.c
+++ b/hw/xics.c
@@ -108,13 +108,13 @@ static void icp_set_cppr(struct icp_state *icp, int server, uint8_t cppr)
     }
 }
 
-static void icp_set_mfrr(struct icp_state *icp, int nr, uint8_t mfrr)
+static void icp_set_mfrr(struct icp_state *icp, int server, uint8_t mfrr)
 {
-    struct icp_server_state *ss = icp->ss + nr;
+    struct icp_server_state *ss = icp->ss + server;
 
     ss->mfrr = mfrr;
     if (mfrr < CPPR(ss)) {
-        icp_check_ipi(icp, nr);
+        icp_check_ipi(icp, server);
     }
 }
 
-- 
1.7.10.4

  parent reply	other threads:[~2012-10-11 11:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 11:47 [Qemu-devel] [0/8] Pending pseries patches David Gibson
2012-10-11 11:47 ` [Qemu-devel] [PATCH 1/8] target-ppc: Extend FPU state for newer POWER CPUs David Gibson
2012-10-11 11:47 ` David Gibson [this message]
2012-10-11 11:47 ` [Qemu-devel] [PATCH 3/8] pseries: Use #define for XICS base irq number David Gibson
2012-10-11 11:47 ` [Qemu-devel] [PATCH 4/8] pseries: Cleanup duplications of ics_valid_irq() code David Gibson
2012-10-11 11:47 ` [Qemu-devel] [PATCH 5/8] pseries: Move XICS initialization before cpu initialization David Gibson
2012-10-11 11:47 ` [Qemu-devel] [PATCH 6/8] pseries: Return the token when we register an RTAS call David Gibson
2012-10-11 11:47 ` [Qemu-devel] [PATCH 7/8] pseries: Allow RTAS tokens without a qemu handler David Gibson
2012-10-11 11:47 ` [Qemu-devel] [PATCH 8/8] pseries: Add tracepoints to the XICS interrupt controller David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349956064-26709-3-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).