qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [RFC 0/7] block: bdrv_img_create(): propagate errors
Date: Thu, 11 Oct 2012 18:26:58 -0300	[thread overview]
Message-ID: <1349990825-2659-1-git-send-email-lcapitulino@redhat.com> (raw)

I'm calling this an RFC because I did it on hurry and it's almost untested,
but I wanted to drop it for early review while I'm out for a public holiday :)

This should improve qmp_transaction() error messages on bdrv_img_create()
failure quite a bit. Also, the "formatting" message is not printed to stdout
anymore when in QMP.

Luiz Capitulino (6):
  block: bdrv_img_create(): add param_ret argument
  block: bdrv_img_create(): move param printing to qemu-img
  block: bdrv_img_create(): add Error ** argument
  qemu-img: img_create(): use Error object
  qmp: qmp_transaction(): pass Error object to bdrv_img_create()
  block: bdrv_img_create(): drop unused code

Paolo Bonzini (1):
  error: add error_set_errno and error_setg_errno

 block.c    | 69 +++++++++++++++++++++++++++-----------------------------------
 block.h    |  7 ++++---
 blockdev.c | 13 ++++++------
 error.c    | 28 +++++++++++++++++++++++++
 error.h    |  9 ++++++++
 qemu-img.c | 18 +++++++++++++---
 6 files changed, 93 insertions(+), 51 deletions(-)

-- 
1.7.12.315.g682ce8b

             reply	other threads:[~2012-10-11 21:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 21:26 Luiz Capitulino [this message]
2012-10-11 21:26 ` [Qemu-devel] [RFC 1/7] error: add error_set_errno and error_setg_errno Luiz Capitulino
2012-10-11 21:27 ` [Qemu-devel] [RFC 2/7] block: bdrv_img_create(): add param_ret argument Luiz Capitulino
2012-10-11 21:27 ` [Qemu-devel] [RFC 3/7] block: bdrv_img_create(): move param printing to qemu-img Luiz Capitulino
2012-10-12  8:29   ` Paolo Bonzini
2012-10-15 21:39     ` Luiz Capitulino
2012-10-11 21:27 ` [Qemu-devel] [RFC 4/7] block: bdrv_img_create(): add Error ** argument Luiz Capitulino
2012-10-11 21:27 ` [Qemu-devel] [RFC 5/7] qemu-img: img_create(): use Error object Luiz Capitulino
2012-10-11 21:27 ` [Qemu-devel] [RFC 6/7] qmp: qmp_transaction(): pass Error object to bdrv_img_create() Luiz Capitulino
2012-10-11 21:27 ` [Qemu-devel] [RFC 7/7] block: bdrv_img_create(): drop unused code Luiz Capitulino
2012-10-12  8:31 ` [Qemu-devel] [RFC 0/7] block: bdrv_img_create(): propagate errors Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349990825-2659-1-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).