From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMQGm-0007X5-04 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 17:26:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMQGk-0005Th-Hc for qemu-devel@nongnu.org; Thu, 11 Oct 2012 17:26:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMQGk-0005TI-95 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 17:26:14 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9BLQC7a032010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Oct 2012 17:26:12 -0400 From: Luiz Capitulino Date: Thu, 11 Oct 2012 18:26:58 -0300 Message-Id: <1349990825-2659-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [RFC 0/7] block: bdrv_img_create(): propagate errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com I'm calling this an RFC because I did it on hurry and it's almost untested, but I wanted to drop it for early review while I'm out for a public holiday :) This should improve qmp_transaction() error messages on bdrv_img_create() failure quite a bit. Also, the "formatting" message is not printed to stdout anymore when in QMP. Luiz Capitulino (6): block: bdrv_img_create(): add param_ret argument block: bdrv_img_create(): move param printing to qemu-img block: bdrv_img_create(): add Error ** argument qemu-img: img_create(): use Error object qmp: qmp_transaction(): pass Error object to bdrv_img_create() block: bdrv_img_create(): drop unused code Paolo Bonzini (1): error: add error_set_errno and error_setg_errno block.c | 69 +++++++++++++++++++++++++++----------------------------------- block.h | 7 ++++--- blockdev.c | 13 ++++++------ error.c | 28 +++++++++++++++++++++++++ error.h | 9 ++++++++ qemu-img.c | 18 +++++++++++++--- 6 files changed, 93 insertions(+), 51 deletions(-) -- 1.7.12.315.g682ce8b