From: Thomas Huth <thuth@redhat.com>
To: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>, qemu-devel@nongnu.org
Cc: philmd@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH 3/3] po/Makefile: Modern shell scripting (use $() instead of ``)
Date: Wed, 17 Oct 2018 11:54:32 +0200 [thread overview]
Message-ID: <134b72ef-0f6a-dd71-e761-0d4ae23e31cf@redhat.com> (raw)
In-Reply-To: <20181017094406.4844-4-maozhongyi@cmss.chinamobile.com>
On 2018-10-17 11:44, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete ``
> and modern $(); It would be nice to convert to using $()
> everywhere.
>
> Cc: philmd@redhat.com
> Cc: peter.maydell@linaro.org
> Cc: thuth@redhat.com
> Cc: sw@weilnetz.de
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
> po/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/po/Makefile b/po/Makefile
> index e47e262ee6..10605e8eb3 100644
> --- a/po/Makefile
> +++ b/po/Makefile
> @@ -36,7 +36,7 @@ clean:
>
> install: $(OBJS)
> for obj in $(OBJS); do \
> - base=`basename $$obj .mo`; \
> + base=$(basename $$obj .mo); \
You're changing a Makefile here, so you need to "escape" the "$" by
doubling it:
base=$$(basename $$obj .mo); \
Thomas
next prev parent reply other threads:[~2018-10-17 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:44 [Qemu-devel] [PATCH 0/3] Modern shell scripting (use $() instead of ``) Mao Zhongyi
2018-10-17 9:44 ` [Qemu-devel] [PATCH 1/3] qemu-iotests: Modern shellscripting " Mao Zhongyi
2018-10-17 9:44 ` [Qemu-devel] [PATCH 2/3] debian-bootstrap.pre: Modern shell scripting " Mao Zhongyi
2018-10-19 11:23 ` Alex Bennée
2018-10-17 9:44 ` [Qemu-devel] [PATCH 3/3] po/Makefile: " Mao Zhongyi
2018-10-17 9:54 ` Thomas Huth [this message]
2018-10-18 2:10 ` [Qemu-devel] [PATCH 3/3] po/Makefile: Modern shell scripting (use $() insteadof ``) maozy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134b72ef-0f6a-dd71-e761-0d4ae23e31cf@redhat.com \
--to=thuth@redhat.com \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).