From: Richard Henderson <richard.henderson@linaro.org>
To: Sven Schnelle <svens@stackframe.org>
Cc: qemu-devel@nongnu.org, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH 1/3] target/hppa: add unit conditions for wide mode
Date: Thu, 21 Mar 2024 09:58:05 -1000 [thread overview]
Message-ID: <134f8055-6b5a-4610-93d3-524d2f3de003@linaro.org> (raw)
In-Reply-To: <20240321184228.611897-1-svens@stackframe.org>
On 3/21/24 08:42, Sven Schnelle wrote:
> Wide mode provides two more conditions, add them.
>
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> ---
> target/hppa/translate.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 8a87996fc1..f493e207e1 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -963,11 +963,22 @@ static DisasCond do_unit_cond(unsigned cf, bool d, TCGv_i64 res,
>
> switch (cf >> 1) {
> case 0: /* never / TR */
> - case 1: /* undefined */
> - case 5: /* undefined */
> cond = cond_make_f();
> break;
>
> + case 1:
Wants a comment for /* SWZ / NWZ */
> + case 5:
/* SWC / NWC */
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-03-21 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:42 [PATCH 1/3] target/hppa: add unit conditions for wide mode Sven Schnelle
2024-03-21 18:42 ` [PATCH 2/3] target/hppa: sub: fix trap on overflow for narrow mode Sven Schnelle
2024-03-21 20:03 ` Richard Henderson
2024-03-21 20:08 ` Sven Schnelle
2024-03-21 18:42 ` [PATCH 3/3] target/hppa: add: " Sven Schnelle
2024-03-21 20:04 ` Richard Henderson
2024-03-21 19:58 ` Richard Henderson [this message]
2024-03-21 20:10 ` [PATCH 1/3] target/hppa: add unit conditions for wide mode Sven Schnelle
2024-03-21 21:06 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134f8055-6b5a-4610-93d3-524d2f3de003@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).