From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 2/9] hw/arm_gic.c: Fix improper DPRINTF output.
Date: Fri, 12 Oct 2012 12:38:25 +0100 [thread overview]
Message-ID: <1350041912-12595-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1350041912-12595-1-git-send-email-peter.maydell@linaro.org>
From: Evgeny Voevodin <e.voevodin@samsung.com>
s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value)
switch (offset) {
case 0x00: /* Control */
s->cpu_enabled[cpu] = (value & 1);
- DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
+ DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
break;
case 0x04: /* Priority mask */
s->priority_mask[cpu] = (value & 0xff);
--
1.7.9.5
next prev parent reply other threads:[~2012-10-12 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 11:38 [Qemu-devel] [PULL 0/9] arm-devs queue Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 1/9] cadence_ttc: Fix 'clear on read' behavior Peter Maydell
2012-10-12 11:38 ` Peter Maydell [this message]
2012-10-12 11:38 ` [Qemu-devel] [PATCH 3/9] hw/ds1338: Fix mishandling of register pointer Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 4/9] hw/ds1338: Recapture current time when register pointer wraps around Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 5/9] hw/ds1338: Remove 'now' field from state struct Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 6/9] hw/ds1338: Implement state save/restore Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 7/9] versatilepb: add gpio pl061 support Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 8/9] zynq_slcr: Fixed ResetValues enum Peter Maydell
2012-10-12 11:38 ` [Qemu-devel] [PATCH 9/9] arm_gic: Rename gic_state to GICState Peter Maydell
2012-10-12 19:16 ` [Qemu-devel] [PULL 0/9] arm-devs queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350041912-12595-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).