qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V3 00/10] replace QEMUOptionParameter with QemuOpts parser
Date: Sun, 14 Oct 2012 20:51:25 +0800	[thread overview]
Message-ID: <1350219095-3378-1-git-send-email-wdongxu@linux.vnet.ibm.com> (raw)

Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here:
http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
Patch 2 and 3 are changed according Paolo's comments.

Patch 4-5: because qemu_opts_create can not fail while id is null, so create
function qemu_opts_create_nofail and use it.

Patch 6: create function qemu_opt_set_number, like qemu_opt_set_bool.

Patch 7: add def_value and use it in qemu_opts_print.

Patch 8: Create functions to pair with QEMUOptionParameter parser.

Patch 9: Use QemuOpts parser in Block.

Patch 10: Remove QEMUOptionParameter parser related code.  

v2->v3:
1) rewrite qemu_opt_set_bool and qemu_opt_set_number according Paolo's coments.
2) split patches to make review easier.

v1->v2:
1) add Luiz's patches.
2) create qemu_opt_set_number() and qemu_opts_create_nofail() functions.
3) add QemuOptsList map to drivers.
4) use original opts parser, not creating new ones.
5) fix other bugs.

Dong Xu Wang (10):
  qemu-option: opt_set(): split it up into more functions
  qemu-option: qemu_opts_validate(): fix duplicated code
  qemu-option: qemu_opt_set_bool(): fix code duplication
  introduce qemu_opts_create_nofail function
  use qemu_opts_create_nofail
  create new function: qemu_opt_set_number
  add def_value and use it in qemu_opts_print.
  Create four opts list related functions
  Use QemuOpts support in block layer
  remove QEMUOptionParameter related functions and struct

 block.c           |   91 +++++-----
 block.h           |    5 +-
 block/cow.c       |   51 +++---
 block/qcow.c      |   64 ++++---
 block/qcow2.c     |  177 +++++++++---------
 block/qed.c       |   90 +++++-----
 block/raw-posix.c |   68 ++++----
 block/raw.c       |   31 ++-
 block/sheepdog.c  |   80 ++++----
 block/vdi.c       |   73 ++++----
 block/vmdk.c      |   79 ++++----
 block/vpc.c       |   56 ++++---
 block/vvfat.c     |   11 +-
 block_int.h       |    6 +-
 blockdev.c        |    2 +-
 qemu-config.c     |    4 +-
 qemu-img.c        |   63 +++----
 qemu-option.c     |  528 +++++++++++++++++++----------------------------------
 qemu-option.h     |   40 +----
 qemu-sockets.c    |   10 +-
 vl.c              |   12 +-
 21 files changed, 693 insertions(+), 848 deletions(-)

             reply	other threads:[~2012-10-14 12:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-14 12:51 Dong Xu Wang [this message]
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 01/10] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 02/10] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 04/10] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 05/10] use qemu_opts_create_nofail Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 06/10] create new function: qemu_opt_set_number Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 07/10] add def_value and use it in qemu_opts_print Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 08/10] Create four opts list related functions Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 09/10] Use QemuOpts support in block layer Dong Xu Wang
2012-10-14 12:51 ` [Qemu-devel] [PATCH V3 10/10] remove QEMUOptionParameter related functions and struct Dong Xu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350219095-3378-1-git-send-email-wdongxu@linux.vnet.ibm.com \
    --to=wdongxu@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).