qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs
Date: Sun, 14 Oct 2012 14:11:09 +0100	[thread overview]
Message-ID: <1350220276-16349-1-git-send-email-peter.maydell@linaro.org> (raw)

This patch series introduces a new logging category to
qemu_log_mask(), for reporting situations which the device
model can cope with but which indicate bugs in the guest.
The most common cause of these is "guest tried to access
a register which doesn't exist". At the moment device models
use an inconsistent mix of "silently ignore", "hw_error(),
killing qemu" and "direct print to stderr" for reporting
this kind of event.

Patches 2-7 are a random selection of ARM devices which I've
switched to using the new LOG_GUEST_ERROR (or the existing
LOG_UNIMP where that is more appropriate). There are obviously
more conversions that could be made; this is just a sample
to demonstrate the utility of the log category.

One question that comes to mind -- should we include qemu-log.h
in qemu-common.h (or some other common header?) rather than
having to include qemu-log.h directly in lots of device model
source files?

Peter Maydell (7):
  qemu-log: Add new log category for guest bugs
  hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR
  hw/pl041: Use LOG_UNIMP
  hw/pl190: Use LOG_GUEST_ERROR
  hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR
  hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR
  hw/pl031: Use LOG_GUEST_ERROR

 hw/pl011.c | 12 ++++++++----
 hw/pl022.c |  9 ++++++---
 hw/pl031.c | 17 +++++++++++------
 hw/pl041.c |  6 ++++--
 hw/pl181.c | 19 +++++++++++--------
 hw/pl190.c |  7 +++++--
 qemu-log.c |  3 +++
 qemu-log.h |  1 +
 8 files changed, 49 insertions(+), 25 deletions(-)

-- 
1.7.11.4

             reply	other threads:[~2012-10-14 13:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-14 13:11 Peter Maydell [this message]
2012-10-14 13:11 ` [Qemu-devel] [PATCH 1/7] qemu-log: Add new log category for guest bugs Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 2/7] hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 3/7] hw/pl041: Use LOG_UNIMP Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 4/7] hw/pl190: Use LOG_GUEST_ERROR Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 5/7] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 6/7] hw/pl022: " Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR Peter Maydell
2012-10-14 14:02 ` [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs Blue Swirl
2012-10-14 15:41   ` Peter Maydell
2012-10-14 15:55     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350220276-16349-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=blauwirbel@gmail.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).