From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNNyZ-0005Ef-R8 for qemu-devel@nongnu.org; Sun, 14 Oct 2012 09:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNNyY-0002Sy-NE for qemu-devel@nongnu.org; Sun, 14 Oct 2012 09:11:27 -0400 Received: from 38.0.169.217.in-addr.arpa ([217.169.0.38]:42693 helo=mnementh.archaic.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNNyY-0002Rm-HE for qemu-devel@nongnu.org; Sun, 14 Oct 2012 09:11:26 -0400 From: Peter Maydell Date: Sun, 14 Oct 2012 14:11:09 +0100 Message-Id: <1350220276-16349-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , patches@linaro.org This patch series introduces a new logging category to qemu_log_mask(), for reporting situations which the device model can cope with but which indicate bugs in the guest. The most common cause of these is "guest tried to access a register which doesn't exist". At the moment device models use an inconsistent mix of "silently ignore", "hw_error(), killing qemu" and "direct print to stderr" for reporting this kind of event. Patches 2-7 are a random selection of ARM devices which I've switched to using the new LOG_GUEST_ERROR (or the existing LOG_UNIMP where that is more appropriate). There are obviously more conversions that could be made; this is just a sample to demonstrate the utility of the log category. One question that comes to mind -- should we include qemu-log.h in qemu-common.h (or some other common header?) rather than having to include qemu-log.h directly in lots of device model source files? Peter Maydell (7): qemu-log: Add new log category for guest bugs hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR hw/pl041: Use LOG_UNIMP hw/pl190: Use LOG_GUEST_ERROR hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR hw/pl031: Use LOG_GUEST_ERROR hw/pl011.c | 12 ++++++++---- hw/pl022.c | 9 ++++++--- hw/pl031.c | 17 +++++++++++------ hw/pl041.c | 6 ++++-- hw/pl181.c | 19 +++++++++++-------- hw/pl190.c | 7 +++++-- qemu-log.c | 3 +++ qemu-log.h | 1 + 8 files changed, 49 insertions(+), 25 deletions(-) -- 1.7.11.4