From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 4/7] hw/pl190: Use LOG_GUEST_ERROR
Date: Sun, 14 Oct 2012 14:11:13 +0100 [thread overview]
Message-ID: <1350220276-16349-5-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1350220276-16349-1-git-send-email-peter.maydell@linaro.org>
If the guest attempts an offset to a nonexistent register, just
log this via LOG_GUEST_ERROR rather than killing QEMU with a hw_error.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/pl190.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/pl190.c b/hw/pl190.c
index 7332f4d..e8b2fc4 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -8,6 +8,7 @@
*/
#include "sysbus.h"
+#include "qemu-log.h"
/* The number of virtual priority levels. 16 user vectors plus the
unvectored IRQ. Chained interrupts would require an additional level
@@ -143,7 +144,8 @@ static uint64_t pl190_read(void *opaque, target_phys_addr_t offset,
case 13: /* DEFVECTADDR */
return s->vect_addr[16];
default:
- hw_error("pl190_read: Bad offset %x\n", (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "pl190_read: Bad offset %x\n", (int)offset);
return 0;
}
}
@@ -202,7 +204,8 @@ static void pl190_write(void *opaque, target_phys_addr_t offset,
}
break;
default:
- hw_error("pl190_write: Bad offset %x\n", (int)offset);
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "pl190_write: Bad offset %x\n", (int)offset);
return;
}
pl190_update(s);
--
1.7.11.4
next prev parent reply other threads:[~2012-10-14 13:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 13:11 [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 1/7] qemu-log: Add new log category for " Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 2/7] hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 3/7] hw/pl041: Use LOG_UNIMP Peter Maydell
2012-10-14 13:11 ` Peter Maydell [this message]
2012-10-14 13:11 ` [Qemu-devel] [PATCH 5/7] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 6/7] hw/pl022: " Peter Maydell
2012-10-14 13:11 ` [Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR Peter Maydell
2012-10-14 14:02 ` [Qemu-devel] [PATCH 0/7] Add LOG_GUEST_ERROR for reporting guest bugs Blue Swirl
2012-10-14 15:41 ` Peter Maydell
2012-10-14 15:55 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350220276-16349-5-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).