From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNNyZ-0005EU-DY for qemu-devel@nongnu.org; Sun, 14 Oct 2012 09:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNNyY-0002Sg-4c for qemu-devel@nongnu.org; Sun, 14 Oct 2012 09:11:27 -0400 Received: from 38.0.169.217.in-addr.arpa ([217.169.0.38]:42693 helo=mnementh.archaic.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNNyX-0002Rm-Ua for qemu-devel@nongnu.org; Sun, 14 Oct 2012 09:11:26 -0400 From: Peter Maydell Date: Sun, 14 Oct 2012 14:11:16 +0100 Message-Id: <1350220276-16349-8-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1350220276-16349-1-git-send-email-peter.maydell@linaro.org> References: <1350220276-16349-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 7/7] hw/pl031: Use LOG_GUEST_ERROR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , patches@linaro.org Use LOG_GUEST_ERROR rather than hw_error or direct fprintf. Signed-off-by: Peter Maydell --- hw/pl031.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/pl031.c b/hw/pl031.c index 9602664..a718d2e 100644 --- a/hw/pl031.c +++ b/hw/pl031.c @@ -14,6 +14,7 @@ #include "sysbus.h" #include "qemu-timer.h" #include "sysemu.h" +#include "qemu-log.h" //#define DEBUG_PL031 @@ -120,11 +121,13 @@ static uint64_t pl031_read(void *opaque, target_phys_addr_t offset, case RTC_MIS: return s->is & s->im; case RTC_ICR: - fprintf(stderr, "qemu: pl031_read: Unexpected offset 0x%x\n", - (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "pl031: read of write-only register at offset 0x%x\n", + (int)offset); break; default: - hw_error("pl031_read: Bad offset 0x%x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "pl031_read: Bad offset 0x%x\n", (int)offset); break; } @@ -167,12 +170,14 @@ static void pl031_write(void * opaque, target_phys_addr_t offset, case RTC_DR: case RTC_MIS: case RTC_RIS: - fprintf(stderr, "qemu: pl031_write: Unexpected offset 0x%x\n", - (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "pl031: write to read-only register at offset 0x%x\n", + (int)offset); break; default: - hw_error("pl031_write: Bad offset 0x%x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "pl031_write: Bad offset 0x%x\n", (int)offset); break; } } -- 1.7.11.4