From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNprN-0003GO-5v for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNprM-0005cI-0C for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:57:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNprL-0005aM-Nx for qemu-devel@nongnu.org; Mon, 15 Oct 2012 14:57:51 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FIvoTt014587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Oct 2012 14:57:50 -0400 From: Jeff Cody Date: Mon, 15 Oct 2012 14:57:48 -0400 Message-Id: <1350327468-11657-1-git-send-email-jcody@redhat.com> Subject: [Qemu-devel] [PATCH] qmp: fix __accept() in qmp.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation from __negotiate_capabilities(), which breaks _accept(). This causes failures in qemu-io python based tests (i.e. tests 030 and 040). This patch creates the sockfile in __accept() as well. --- QMP/qmp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/QMP/qmp.py b/QMP/qmp.py index 33c7d36..32510a1 100644 --- a/QMP/qmp.py +++ b/QMP/qmp.py @@ -96,6 +96,7 @@ class QEMUMonitorProtocol: @raise QMPCapabilitiesError if fails to negotiate capabilities """ self.__sock, _ = self.__sock.accept() + self.__sockfile = self.__sock.makefile() return self.__negotiate_capabilities() def cmd_obj(self, qmp_cmd): -- 1.7.11.4