From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNrji-0002mN-Tq for qemu-devel@nongnu.org; Mon, 15 Oct 2012 16:58:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNrji-0001ux-04 for qemu-devel@nongnu.org; Mon, 15 Oct 2012 16:58:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNrjh-0001us-NR for qemu-devel@nongnu.org; Mon, 15 Oct 2012 16:58:05 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FKw4v0029467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Oct 2012 16:58:04 -0400 From: Jeff Cody Date: Mon, 15 Oct 2012 16:58:02 -0400 Message-Id: <1350334682-27158-1-git-send-email-jcody@redhat.com> Subject: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, lcapitulino@redhat.com In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation from __negotiate_capabilities(), which breaks _accept(). This causes failures in qemu-io python based tests (i.e. tests 030 and 040). This patch creates the sockfile in __accept() as well. Signed-off-by: Jeff Cody --- QMP/qmp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/QMP/qmp.py b/QMP/qmp.py index 33c7d36..32510a1 100644 --- a/QMP/qmp.py +++ b/QMP/qmp.py @@ -96,6 +96,7 @@ class QEMUMonitorProtocol: @raise QMPCapabilitiesError if fails to negotiate capabilities """ self.__sock, _ = self.__sock.accept() + self.__sockfile = self.__sock.makefile() return self.__negotiate_capabilities() def cmd_obj(self, qmp_cmd): -- 1.7.11.4