From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
kashyap.cv@gmail.com, "Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/2] qemu-img: Add --backing-chain option to info command
Date: Wed, 17 Oct 2012 14:02:30 +0200 [thread overview]
Message-ID: <1350475352-9607-1-git-send-email-stefanha@redhat.com> (raw)
This series adds the --backing-chain option for enumerating the backing file
chain. Given the topmost image it will print qemu-img info information for
each image file in the chain.
Special care needs to be taken when image files form an infinite loop. This is
very unusual, most like due to malicious image files. Nevertheless, qemu-img
must be robust against invalid inputs so we explicit check for this.
v3:
* Use ImageInfoList to avoid manually outputting JSON and to make the code
more QAPI-friendly.
* Solve the output vs error messages issues by printing a detailed error
message but no image info. To dig into a broken image chain, rerun without
--backing-chain. This is different from what I initially tried but is much
cleaner because it doesn't produce confusing output.
* rm -f $TEST_IMG.[123].base [Kevin]
* Include --output=json in test case [Kevin]
* Rename test case to free 043 number [Eric]
Stefan Hajnoczi (2):
qemu-img: Add --backing-chain option to info command
qemu-iotests: Add 043 backing file chain infinite loop test
qemu-img.c | 167 +++++++++++++++++++++++++++++++++++++++----
tests/qemu-iotests/043 | 94 ++++++++++++++++++++++++
tests/qemu-iotests/043.out | 66 +++++++++++++++++
tests/qemu-iotests/common.rc | 10 +++
tests/qemu-iotests/group | 1 +
5 files changed, 324 insertions(+), 14 deletions(-)
create mode 100755 tests/qemu-iotests/043
create mode 100644 tests/qemu-iotests/043.out
--
1.7.11.7
next reply other threads:[~2012-10-17 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 12:02 Stefan Hajnoczi [this message]
2012-10-17 12:02 ` [Qemu-devel] [PATCH v3 1/2] qemu-img: Add --backing-chain option to info command Stefan Hajnoczi
2012-10-17 12:02 ` [Qemu-devel] [PATCH v3 2/2] qemu-iotests: Add 043 backing file chain infinite loop test Stefan Hajnoczi
2012-10-17 14:47 ` [Qemu-devel] [PATCH v3 0/2] qemu-img: Add --backing-chain option to info command Kevin Wolf
2012-10-17 14:51 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350475352-9607-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=benoit@irqsave.net \
--cc=kashyap.cv@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).