From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTTu-00056d-UF for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:16:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOTTl-0002h6-4d for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:16:18 -0400 Received: from e24smtp02.br.ibm.com ([32.104.18.86]:54239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTTk-0002SK-Q6 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:16:09 -0400 Received: from /spool/local by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Oct 2012 10:15:52 -0300 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 5E1B31DC0054 for ; Wed, 17 Oct 2012 09:15:46 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9HDFKQX1749034 for ; Wed, 17 Oct 2012 10:15:20 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9HDFj9K008891 for ; Wed, 17 Oct 2012 10:15:45 -0300 From: Eduardo Otubo Date: Wed, 17 Oct 2012 10:15:12 -0300 Message-Id: <1350479712-15082-4-git-send-email-otubo@linux.vnet.ibm.com> In-Reply-To: <1350479712-15082-1-git-send-email-otubo@linux.vnet.ibm.com> References: <1350479712-15082-1-git-send-email-otubo@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 4/4] Warning messages on net devices hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pmoore@redhat.com, aliguori@us.ibm.com, coreyb@linux.vnet.ibm.com, Eduardo Otubo With the inclusion of the new "double whitelist" seccomp filter, Qemu won't be able to execve() in runtime, thus, no hotplug net devices allowed. Signed-off-by: Eduardo Otubo --- hmp.c | 6 ++++++ net.c | 13 +++++++++++++ 2 files changed, 19 insertions(+) diff --git a/hmp.c b/hmp.c index 70bdec2..f258338 100644 --- a/hmp.c +++ b/hmp.c @@ -1091,6 +1091,12 @@ void hmp_netdev_add(Monitor *mon, const QDict *qdict) Error *err = NULL; QemuOpts *opts; +#ifdef CONFIG_SECCOMP + error_set(&err, ERROR_CLASS_GENERIC_ERROR, + "Cannot hotplug TAP device when -sandbox is in effect"); + goto out; +#endif + opts = qemu_opts_from_qdict(qemu_find_opts("netdev"), qdict, &err); if (error_is_set(&err)) { goto out; diff --git a/net.c b/net.c index ae4bc0d..a652ee9 100644 --- a/net.c +++ b/net.c @@ -752,6 +752,12 @@ void net_host_device_add(Monitor *mon, const QDict *qdict) Error *local_err = NULL; QemuOpts *opts; +#ifdef CONFIG_SECCOMP + error_set(&local_err, ERROR_CLASS_GENERIC_ERROR, + "Cannot hotplug TAP device when -sandbox is in effect"); + goto out; +#endif + if (!net_host_check_device(device)) { monitor_printf(mon, "invalid host network device %s\n", device); return; @@ -765,6 +771,7 @@ void net_host_device_add(Monitor *mon, const QDict *qdict) qemu_opt_set(opts, "type", device); net_client_init(opts, 0, &local_err); +out: if (error_is_set(&local_err)) { qerror_report_err(local_err); error_free(local_err); @@ -800,6 +807,12 @@ int qmp_netdev_add(Monitor *mon, const QDict *qdict, QObject **ret) QemuOptsList *opts_list; QemuOpts *opts; +#ifdef CONFIG_SECCOMP + error_set(&local_err, ERROR_CLASS_GENERIC_ERROR, + "Cannot hotplug TAP device when -sandbox is in effect"); + goto exit_err; +#endif + opts_list = qemu_find_opts_err("netdev", &local_err); if (error_is_set(&local_err)) { goto exit_err; -- 1.7.12