From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTgc-00025E-PH for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:29:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOTgU-0006Ns-TE for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:29:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOTgU-0006NO-M6 for qemu-devel@nongnu.org; Wed, 17 Oct 2012 09:29:18 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HDTIM6026897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 09:29:18 -0400 From: Gerd Hoffmann Date: Wed, 17 Oct 2012 15:29:07 +0200 Message-Id: <1350480554-23281-8-git-send-email-kraxel@redhat.com> In-Reply-To: <1350480554-23281-1-git-send-email-kraxel@redhat.com> References: <1350480554-23281-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Currently it is inconstent, PixelFormat->amask is left unset whereas abits and amax and ashift are filled. As an alpha channel doesn't make sense for the vga framebuffer leave all alpha fields clear. Signed-off-by: Gerd Hoffmann --- console.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/console.c b/console.c index 48d88e4..d28b75e 100644 --- a/console.c +++ b/console.c @@ -1715,18 +1715,15 @@ PixelFormat qemu_default_pixelformat(int bpp) pf.rmask = 0x00FF0000; pf.gmask = 0x0000FF00; pf.bmask = 0x000000FF; - pf.amax = 255; pf.rmax = 255; pf.gmax = 255; pf.bmax = 255; - pf.ashift = 24; pf.rshift = 16; pf.gshift = 8; pf.bshift = 0; pf.rbits = 8; pf.gbits = 8; pf.bbits = 8; - pf.abits = 8; break; default: break; -- 1.7.1