qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Fleytman <dmitry@daynix.com>
To: qemu-devel@nongnu.org
Cc: Yan Vugenfirer <yan@daynix.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Dmitry Fleytman <dmitry@daynix.com>,
	Chris Webb <chris.webb@elastichosts.com>,
	Richard Davies <richard.davies@elastichosts.com>
Subject: [Qemu-devel] [PATCH V2] E1000 RX ring management fix
Date: Thu, 18 Oct 2012 20:59:10 +0200	[thread overview]
Message-ID: <1350586751-19050-1-git-send-email-dmitry@daynix.com> (raw)

Following patch fixes improper RX ring management E1000 code

Changes from version 1:
    1st patch changed so it drops check_rxov field because it is redundant and leads to race conditions
    See commit description for details

    2nd patch (live migration) dropped because corresponding field got deleted

Also I've made short experiment with an Intel adapter controlled by e1000e driver.
Indeed I saw no RX indication attempt when RX ring's RDH and RDT are equal.

Dmitry Fleytman (1):
  Drop check_rxov, always treat RX ring with RHD == RDT as empty

 hw/e1000.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
1.7.11.4

             reply	other threads:[~2012-10-18 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 18:59 Dmitry Fleytman [this message]
2012-10-18 18:59 ` [Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty Dmitry Fleytman
2012-10-18 19:20   ` Peter Maydell
2012-10-18 20:59     ` Dmitry Fleytman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350586751-19050-1-git-send-email-dmitry@daynix.com \
    --to=dmitry@daynix.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=chris.webb@elastichosts.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.davies@elastichosts.com \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).