From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP2Xy-0004GS-9b for qemu-devel@nongnu.org; Thu, 18 Oct 2012 22:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TP2Xx-0002oo-1C for qemu-devel@nongnu.org; Thu, 18 Oct 2012 22:42:50 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:49553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP2Xw-0002dj-J2 for qemu-devel@nongnu.org; Thu, 18 Oct 2012 22:42:48 -0400 Received: by mail-oa0-f45.google.com with SMTP id i18so3273oag.4 for ; Thu, 18 Oct 2012 19:42:48 -0700 (PDT) Sender: fluxion From: Michael Roth Date: Thu, 18 Oct 2012 21:42:05 -0500 Message-Id: <1350614540-28583-12-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1350614540-28583-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1350614540-28583-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 11/26] qapi: QmpInputVisitor, don't re-allocate memory in start_struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, blauwirbel@gmail.com, pbonzini@redhat.com If we're given a pointer that has already be initialized to a non-NULL value, don't attempt to allocate memory for the object as we'll likely clobber something we weren't supposed to. Also, fix up a check in the unit test that may fail as a result of this change do to it not initializing the object to NULL before-hand and thus depending on this behavior to clobber a potentially garbage ptr value. This is needed to handle embedded/non-pointer struct fields. Signed-off-by: Michael Roth --- qapi/qmp-input-visitor.c | 2 +- tests/test-qmp-input-visitor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index 635106e..c4388f3 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qmp-input-visitor.c @@ -132,7 +132,7 @@ static void qmp_input_start_struct(Visitor *v, void **obj, const char *kind, return; } - if (obj) { + if (obj && *obj == NULL) { *obj = g_malloc0(size); } } diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visitor.c index 8f5a509..58e04f1 100644 --- a/tests/test-qmp-input-visitor.c +++ b/tests/test-qmp-input-visitor.c @@ -247,7 +247,7 @@ static void test_visitor_in_union(TestInputVisitorData *data, { Visitor *v; Error *err = NULL; - UserDefUnion *tmp; + UserDefUnion *tmp = NULL; v = visitor_input_test_init(data, "{ 'type': 'b', 'data' : { 'integer': 42 } }"); -- 1.7.9.5