qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 10/29] qemu-char: ask and print error information from qemu-sockets
Date: Fri, 19 Oct 2012 15:31:49 +0200	[thread overview]
Message-ID: <1350653528-5834-11-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1350653528-5834-1-git-send-email-pbonzini@redhat.com>

Before:

    $ qemu-system-x86_64 -monitor tcp:localhost:6000
    (starts despite error)

    $ qemu-system-x86_64 -monitor tcp:foo.bar:12345
    getaddrinfo(foo.bar,12345): Name or service not known
    chardev: opening backend "socket" failed

    $ qemu-system-x86_64 -monitor tcp:localhost:443,server=on
    inet_listen_opts: bind(ipv4,127.0.0.1,443): Permission denied
    inet_listen_opts: FAILED
    chardev: opening backend "socket" failed

After:

    $ x86_64-softmmu/qemu-system-x86_64 -monitor tcp:localhost:6000
    x86_64-softmmu/qemu-system-x86_64: -monitor tcp:localhost:6000: Failed to connect to socket: Connection refused
    chardev: opening backend "socket" failed

    $ x86_64-softmmu/qemu-system-x86_64 -monitor tcp:foo.bar:12345
    qemu-system-x86_64: -monitor tcp:foo.bar:12345: address resolution failed for foo.bar:12345: Name or service not known
    chardev: opening backend "socket" failed

    $ x86_64-softmmu/qemu-system-x86_64 -monitor tcp:localhost:443,server=on
    qemu-system-x86_64: -monitor tcp:localhost:443,server=on: Failed to bind socket: Permission denied
    chardev: opening backend "socket" failed

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu-char.c | 23 +++++++++++++++++------
 1 file modificato, 17 inserzioni(+), 6 rimozioni(-)

diff --git a/qemu-char.c b/qemu-char.c
index 8ebd582..04b5c23 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2097,12 +2097,13 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts)
 {
     CharDriverState *chr = NULL;
     NetCharDriver *s = NULL;
+    Error *local_err = NULL;
     int fd = -1;
 
     chr = g_malloc0(sizeof(CharDriverState));
     s = g_malloc0(sizeof(NetCharDriver));
 
-    fd = inet_dgram_opts(opts, NULL);
+    fd = inet_dgram_opts(opts, &local_err);
     if (fd < 0) {
         fprintf(stderr, "inet_dgram_opts failed\n");
         goto return_err;
@@ -2118,6 +2119,10 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts)
     return chr;
 
 return_err:
+    if (local_err) {
+        qerror_report_err(local_err);
+        error_free(local_err);
+    }
     g_free(chr);
     g_free(s);
     if (fd >= 0) {
@@ -2428,6 +2433,7 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
 {
     CharDriverState *chr = NULL;
     TCPCharDriver *s = NULL;
+    Error *local_err = NULL;
     int fd = -1;
     int is_listen;
     int is_waitconnect;
@@ -2448,15 +2454,15 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
 
     if (is_unix) {
         if (is_listen) {
-            fd = unix_listen_opts(opts, NULL);
+            fd = unix_listen_opts(opts, &local_err);
         } else {
-            fd = unix_connect_opts(opts, NULL, NULL, NULL);
+            fd = unix_connect_opts(opts, &local_err, NULL, NULL);
         }
     } else {
         if (is_listen) {
-            fd = inet_listen_opts(opts, 0, NULL);
+            fd = inet_listen_opts(opts, 0, &local_err);
         } else {
-            fd = inet_connect_opts(opts, NULL, NULL, NULL);
+            fd = inet_connect_opts(opts, &local_err, NULL, NULL);
         }
     }
     if (fd < 0) {
@@ -2517,8 +2523,13 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
     return chr;
 
  fail:
-    if (fd >= 0)
+    if (local_err) {
+        qerror_report_err(local_err);
+        error_free(local_err);
+    }
+    if (fd >= 0) {
         closesocket(fd);
+    }
     g_free(s);
     g_free(chr);
     return NULL;
-- 
1.7.12.1

  parent reply	other threads:[~2012-10-19 13:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 13:31 [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 01/29] error: add error_set_errno and error_setg_errno Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 02/29] qemu-sockets: add Error ** to all functions Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 03/29] qemu-sockets: unix_listen and unix_connect are portable Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 04/29] qemu-sockets: add nonblocking connect for Unix sockets Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 05/29] migration: avoid using error_is_set and thus relying on errp != NULL Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 06/29] migration: centralize call to migrate_fd_error() Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 07/29] migration: use qemu-sockets to establish Unix sockets Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 08/29] migration (outgoing): add error propagation for all protocols Paolo Bonzini
2012-10-22 15:52   ` Markus Armbruster
2012-10-23 11:27     ` Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 09/29] migration (incoming): add error propagation to fd and exec protocols Paolo Bonzini
2012-10-19 13:31 ` Paolo Bonzini [this message]
2012-10-19 13:31 ` [Qemu-devel] [PATCH 11/29] nbd: ask and print error information from qemu-sockets Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 12/29] qemu-ga: " Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 13/29] vnc: avoid Yoda conditionals Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 14/29] vnc: introduce a single label for error returns Paolo Bonzini
2012-10-22 15:49   ` Markus Armbruster
2012-10-23 11:32     ` Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 15/29] vnc: reorganize code for reverse mode Paolo Bonzini
2012-10-22 15:39   ` Markus Armbruster
2012-10-19 13:31 ` [Qemu-devel] [PATCH 16/29] vnc: add error propagation to vnc_display_open Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 17/29] qemu-sockets: include strerror or gai_strerror output in error messages Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 18/29] qemu-sockets: add error propagation to inet_connect_addr Paolo Bonzini
2012-10-22 15:53   ` Markus Armbruster
2012-10-19 13:31 ` [Qemu-devel] [PATCH 19/29] qemu-sockets: add error propagation to inet_dgram_opts Paolo Bonzini
2012-10-19 13:31 ` [Qemu-devel] [PATCH 20/29] qemu-sockets: add error propagation to inet_parse Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 21/29] qemu-sockets: add error propagation to Unix socket functions Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 22/29] vnc: drop QERR_VNC_SERVER_FAILED Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 23/29] build: add QAPI files to the tools Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 24/29] qapi: add socket address types Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 25/29] qemu-sockets: return InetSocketAddress from inet_parse Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 26/29] qemu-sockets: add socket_listen, socket_connect, socket_parse Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 27/29] block: prepare code for adding block notifiers Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 28/29] block: add close notifiers Paolo Bonzini
2012-10-19 13:32 ` [Qemu-devel] [PATCH 29/29] qmp: add NBD server commands Paolo Bonzini
2012-10-22 15:59 ` [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server Markus Armbruster
2012-10-22 19:53 ` Anthony Liguori
2012-10-23 12:34   ` Paolo Bonzini
2012-10-23 15:27     ` Paolo Bonzini
2012-10-23 21:24       ` Paolo Bonzini
2012-10-26 15:33 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350653528-5834-11-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).