qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 4/6] qemu-img: img_create(): drop unneeded goto and ret variable
Date: Fri, 19 Oct 2012 11:28:03 -0300	[thread overview]
Message-ID: <1350656885-6485-5-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1350656885-6485-1-git-send-email-lcapitulino@redhat.com>

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qemu-img.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index a5f2969..dafe705 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -294,7 +294,7 @@ static int add_old_style_options(const char *fmt, QEMUOptionParameter *list,
 
 static int img_create(int argc, char **argv)
 {
-    int c, ret = 0;
+    int c;
     uint64_t img_size = -1;
     const char *fmt = "raw";
     const char *base_fmt = NULL;
@@ -351,15 +351,13 @@ static int img_create(int argc, char **argv)
             error_report("Invalid image size specified! You may use k, M, G or "
                   "T suffixes for ");
             error_report("kilobytes, megabytes, gigabytes and terabytes.");
-            ret = -1;
-            goto out;
+            return 1;
         }
         img_size = (uint64_t)sval;
     }
 
     if (options && is_help_option(options)) {
-        ret = print_block_option_help(filename, fmt);
-        goto out;
+        return print_block_option_help(filename, fmt);
     }
 
     bdrv_img_create(filename, fmt, base_filename, base_fmt,
@@ -367,13 +365,9 @@ static int img_create(int argc, char **argv)
     if (error_is_set(&local_err)) {
         error_report("%s", error_get_pretty(local_err));
         error_free(local_err);
-        ret = -1;
-    }
-
-out:
-    if (ret) {
         return 1;
     }
+
     return 0;
 }
 
-- 
1.7.12.315.g682ce8b

  parent reply	other threads:[~2012-10-19 14:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 14:27 [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors Luiz Capitulino
2012-10-19 14:28 ` [Qemu-devel] [PATCH 1/6] error: add error_set_errno and error_setg_errno Luiz Capitulino
2012-10-19 14:28 ` [Qemu-devel] [PATCH 2/6] block: bdrv_img_create(): add Error ** argument Luiz Capitulino
2012-10-19 14:28 ` [Qemu-devel] [PATCH 3/6] qemu-img: img_create(): pass Error object to bdrv_img_create() Luiz Capitulino
2012-10-19 14:28 ` Luiz Capitulino [this message]
2012-10-19 14:28 ` [Qemu-devel] [PATCH 5/6] qmp: qmp_transaction(): " Luiz Capitulino
2012-10-19 14:28 ` [Qemu-devel] [PATCH 6/6] block: bdrv_img_create(): drop unused error handling code Luiz Capitulino
2012-11-02 13:25 ` [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors Luiz Capitulino
2012-11-02 13:40   ` Kevin Wolf
2012-11-02 13:42     ` Luiz Capitulino
2012-11-29 16:34       ` Luiz Capitulino
2012-11-30 11:39         ` Kevin Wolf
2012-11-30 11:44           ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350656885-6485-5-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).