From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPKHz-0005pM-Q0 for qemu-devel@nongnu.org; Fri, 19 Oct 2012 17:39:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPKHt-0005TH-EP for qemu-devel@nongnu.org; Fri, 19 Oct 2012 17:39:31 -0400 Received: from hall.aurel32.net ([88.191.126.93]:41848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPKHt-0005Sf-3l for qemu-devel@nongnu.org; Fri, 19 Oct 2012 17:39:25 -0400 From: Aurelien Jarno Date: Fri, 19 Oct 2012 23:38:59 +0200 Message-Id: <1350682755-31635-11-git-send-email-aurelien@aurel32.net> In-Reply-To: <1350682755-31635-1-git-send-email-aurelien@aurel32.net> References: <1350682755-31635-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v3 10/26] tcg: don't explicitly save globals and temps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno The liveness analysis ensures that globals and temps are at the correct state at a basic block end or with an op with side effects. Avoid looping on all temps, this can be time consuming on targets with a lot of globals. Keep an assert in debug mode. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/tcg.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 8333667..840e252 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1648,8 +1648,14 @@ static inline void temp_sync(TCGContext *s, int temp, TCGRegSet allocated_regs) temporary registers needs to be allocated to store a constant. */ static inline void temp_save(TCGContext *s, int temp, TCGRegSet allocated_regs) { +#ifdef USE_LIVENESS_ANALYSIS + /* The liveness analysis already ensures that globals are back + in memory. Keep an assert for safety. */ + assert(s->temps[temp].val_type == TEMP_VAL_MEM || s->temps[temp].fixed_reg); +#else temp_sync(s, temp, allocated_regs); temp_dead(s, temp); +#endif } /* save globals to their canonical location and assume they can be @@ -1676,7 +1682,13 @@ static void tcg_reg_alloc_bb_end(TCGContext *s, TCGRegSet allocated_regs) if (ts->temp_local) { temp_save(s, i, allocated_regs); } else { +#ifdef USE_LIVENESS_ANALYSIS + /* The liveness analysis already ensures that temps are dead. + Keep an assert for safety. */ + assert(ts->val_type == TEMP_VAL_DEAD); +#else temp_dead(s, i); +#endif } } -- 1.7.10.4