qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v3 08/26] tcg: always mark dead input arguments as dead
Date: Fri, 19 Oct 2012 23:38:57 +0200	[thread overview]
Message-ID: <1350682755-31635-9-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1350682755-31635-1-git-send-email-aurelien@aurel32.net>

Always mark dead input arguments as dead, even if the op is at the basic
block end. This will allow to check that all temps are correctly saved.

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 tcg/tcg.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tcg/tcg.c b/tcg/tcg.c
index b219a6d..d81b628 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1874,16 +1874,16 @@ static void tcg_reg_alloc_op(TCGContext *s,
     iarg_end: ;
     }
     
+    /* mark dead temporaries and free the associated registers */
+    for (i = nb_oargs; i < nb_oargs + nb_iargs; i++) {
+        if (IS_DEAD_ARG(i)) {
+            temp_dead(s, args[i]);
+        }
+    }
+
     if (def->flags & TCG_OPF_BB_END) {
         tcg_reg_alloc_bb_end(s, allocated_regs);
     } else {
-        /* mark dead temporaries and free the associated registers */
-        for(i = nb_oargs; i < nb_oargs + nb_iargs; i++) {
-            if (IS_DEAD_ARG(i)) {
-                temp_dead(s, args[i]);
-            }
-        }
-        
         if (def->flags & TCG_OPF_CALL_CLOBBER) {
             /* XXX: permit generic clobber register list ? */ 
             for(reg = 0; reg < TCG_TARGET_NB_REGS; reg++) {
-- 
1.7.10.4

  parent reply	other threads:[~2012-10-19 21:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 21:38 [Qemu-devel] [PATCH v3 00/26] tcg: rework liveness analysis and register allocator Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 01/26] tcg: add temp_dead() Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 02/26] tcg: add tcg_reg_sync() Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 03/26] tcg: add temp_sync() Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 04/26] tcg: sync output arguments on liveness request Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 05/26] tcg: rework liveness analysis Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 06/26] tcg: improve tcg_reg_alloc_movi() Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH 07/26] tcg: rewrite tcg_reg_alloc_mov() Aurelien Jarno
2012-10-19 21:38 ` Aurelien Jarno [this message]
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 09/26] tcg: start with local temps in TEMP_VAL_MEM state Aurelien Jarno
2012-10-19 21:38 ` [Qemu-devel] [PATCH v3 10/26] tcg: don't explicitly save globals and temps Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 11/26] tcg: fix some op flags Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 12/26] tcg: forbid ld/st function to modify globals Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 13/26] tcg: synchronize globals for ops with side effects Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 14/26] tcg: rework TCG helper flags Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 15/26] target-alpha: rename " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 16/26] target-arm: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 17/26] target-cris: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 18/26] target-i386: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 19/26] target-microblaze: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 20/26] target-mips: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 21/26] target-ppc: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 22/26] target-s390x: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 23/26] target-sh4: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 24/26] target-sparc: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 25/26] target-xtensa: " Aurelien Jarno
2012-10-19 21:39 ` [Qemu-devel] [PATCH v3 26/26] tcg: remove compatiblity call flags Aurelien Jarno
2012-10-21 20:35 ` [Qemu-devel] [PATCH v3 00/26] tcg: rework liveness analysis and register allocator Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350682755-31635-9-git-send-email-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).