From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQdX5-0000x4-EY for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQdWz-0007Ba-Lk for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:24:31 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:50967 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQdWz-0007BH-CN for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:24:25 -0400 From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Tue, 23 Oct 2012 14:23:47 +0200 Message-Id: <1350995029-29128-10-git-send-email-benoit@irqsave.net> In-Reply-To: <1350995029-29128-1-git-send-email-benoit@irqsave.net> References: <1350995029-29128-1-git-send-email-benoit@irqsave.net> Subject: [Qemu-devel] [PATCH 09/11] quorum: Add quorum_getlength(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , stefanha@redhat.com Check that every bs file return the same length. If not return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet --- block/quorum.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 6d76c49..a01f712 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -604,12 +604,32 @@ static coroutine_fn int quorum_co_flush(BlockDriverState *bs) return 0; } +static int64_t quorum_getlength(BlockDriverState *bs) +{ + BDRVQuorumState *s = bs->opaque; + int64_t result; + int i; + + /* check that every file have the same length */ + result = bdrv_getlength(s->bs[0]); + for (i = 1; i < s->total; i++) { + int64_t value = bdrv_getlength(s->bs[i]); + if (value != result) { + return -EIO; + } + } + + return result; +} + static BlockDriver bdrv_quorum = { .format_name = "quorum", .protocol_name = "quorum", .instance_size = sizeof(BDRVQuorumState), + .bdrv_getlength = quorum_getlength, + .bdrv_file_open = quorum_open, .bdrv_close = quorum_close, .bdrv_co_flush_to_disk = quorum_co_flush, -- 1.7.10.4