From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>, Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 4/4] target-arm: Remove out of date FIXME regarding saturating arithmetic
Date: Wed, 24 Oct 2012 14:03:01 +0100 [thread overview]
Message-ID: <1351083781-3616-5-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1351083781-3616-1-git-send-email-peter.maydell@linaro.org>
Remove an out of date FIXME regarding the saturating arithmetic helpers:
we now do pass a pointer to CPUARMState to these helpers, and since
the AREG0 changes went in there is no difference between helper.c
and op_helper.c and therefore no point in moving the functions.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/op_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
index aef592a..6e3ab90 100644
--- a/target-arm/op_helper.c
+++ b/target-arm/op_helper.c
@@ -93,8 +93,6 @@ void tlb_fill(CPUARMState *env, target_ulong addr, int is_write, int mmu_idx,
}
#endif
-/* FIXME: Pass an explicit pointer to QF to CPUARMState, and move saturating
- instructions into helper.c */
uint32_t HELPER(add_setq)(CPUARMState *env, uint32_t a, uint32_t b)
{
uint32_t res = a + b;
--
1.7.9.5
next prev parent reply other threads:[~2012-10-24 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 13:02 [Qemu-devel] [PULL 0/4] target-arm queue Peter Maydell
2012-10-24 13:02 ` [Qemu-devel] [PATCH 1/4] arm-semi.c: Handle get/put_user() failure accessing arguments Peter Maydell
2012-10-24 13:02 ` [Qemu-devel] [PATCH 2/4] target-arm: Use TCG operation for Neon 64 bit negation Peter Maydell
2012-10-24 13:03 ` [Qemu-devel] [PATCH 3/4] target-arm: Implement abs_i32 inline rather than as a helper Peter Maydell
2012-10-24 13:03 ` Peter Maydell [this message]
2012-10-27 16:52 ` [Qemu-devel] [PULL 0/4] target-arm queue Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351083781-3616-5-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).