From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR1hW-0000IC-Nw for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TR1hN-0007wN-AX for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:12:54 -0400 Received: from egg.sh.bytemark.co.uk ([212.110.161.171]:58541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TR1hN-0007wF-4g for qemu-devel@nongnu.org; Wed, 24 Oct 2012 10:12:45 -0400 From: Nicholas Thomas In-Reply-To: <5087F6D4.9030601@redhat.com> References: <5086728B.1010809@redhat.com> <1350990519.16343.255.camel@eboracum.office.bytemark.co.uk> <20121023150225.GB17080@jl-vm1.vm.bytemark.co.uk> <1351080994.16343.293.camel@eboracum.office.bytemark.co.uk> <5087F53E.6050705@redhat.com> <5087F6D4.9030601@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 24 Oct 2012 15:12:43 +0100 Message-ID: <1351087963.16343.294.camel@eboracum.office.bytemark.co.uk> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , qemu-devel@nongnu.org On Wed, 2012-10-24 at 16:10 +0200, Paolo Bonzini wrote: > Il 24/10/2012 16:03, Paolo Bonzini ha scritto: > > Il 24/10/2012 14:16, Nicholas Thomas ha scritto: > >> > >> I've also just noticed that flush & discard don't take the send_mutex > >> before writing to the socket. That can't be intentional, surely? Paolo? > > > > No, it's a bug. > > Hmm, why do you say it doesn't take the mutex? nbd_co_flush and > nbd_co_discard all call nbd_co_send_request, which takes the mutex. > > Paolo Sorry, brain fail. You're right: no bug :) /Nick