qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: andre.przywara@amd.com, kvm@vger.kernel.org,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Avi Kivity" <avi@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [QEMU PATCH 1/3] target-i385: make cpu_x86_fill_host() void
Date: Wed, 24 Oct 2012 19:44:05 -0200	[thread overview]
Message-ID: <1351115047-27828-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1351115047-27828-1-git-send-email-ehabkost@redhat.com>

The return value of that function is always 0, and is always ignored.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 38fca92..42171c9 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -742,7 +742,7 @@ static int cpu_x86_fill_model_id(char *str)
     return 0;
 }
 
-static int cpu_x86_fill_host(x86_def_t *x86_cpu_def)
+static void cpu_x86_fill_host(x86_def_t *x86_cpu_def)
 {
     uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0;
 
@@ -795,8 +795,6 @@ static int cpu_x86_fill_host(x86_def_t *x86_cpu_def)
      * unsupported ones later.
      */
     x86_cpu_def->svm_features = -1;
-
-    return 0;
 }
 
 static int unavailable_host_feature(struct model_features_t *f, uint32_t mask)
-- 
1.7.11.7

  reply	other threads:[~2012-10-24 21:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 21:44 [Qemu-devel] [QEMU PATCH 0/3] Fix -cpu host and enforce/check to use GET_SUPPORTED_CPUID Eduardo Habkost
2012-10-24 21:44 ` Eduardo Habkost [this message]
2012-10-24 21:44 ` [Qemu-devel] [QEMU PATCH 2/3] target-i386: cpu: make -cpu host/check/enforce code KVM-specific Eduardo Habkost
2012-10-24 21:44 ` [Qemu-devel] [QEMU PATCH 3/3] target-i386: kvm_cpu_fill_host: use GET_SUPPORTED_CPUID Eduardo Habkost
2012-10-29 19:34 ` [Qemu-devel] [QEMU PATCH 0/3] Fix -cpu host and enforce/check to " Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351115047-27828-2-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=andre.przywara@amd.com \
    --cc=avi@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).