qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 07/12] hw/arm_gic: Use LOG_GUEST_ERROR
Date: Thu, 25 Oct 2012 13:57:42 +0100	[thread overview]
Message-ID: <1351169867-5466-8-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1351169867-5466-1-git-send-email-peter.maydell@linaro.org>

Use LOG_GUEST_ERROR to report guest accesses to bad offsets.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm_gic.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index ce16e83..f9e423f 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -324,7 +324,8 @@ static uint32_t gic_dist_readb(void *opaque, hwaddr offset)
     }
     return res;
 bad_reg:
-    hw_error("gic_dist_readb: Bad offset %x\n", (int)offset);
+    qemu_log_mask(LOG_GUEST_ERROR,
+                  "gic_dist_readb: Bad offset %x\n", (int)offset);
     return 0;
 }
 
@@ -487,7 +488,8 @@ static void gic_dist_writeb(void *opaque, hwaddr offset,
     gic_update(s);
     return;
 bad_reg:
-    hw_error("gic_dist_writeb: Bad offset %x\n", (int)offset);
+    qemu_log_mask(LOG_GUEST_ERROR,
+                  "gic_dist_writeb: Bad offset %x\n", (int)offset);
 }
 
 static void gic_dist_writew(void *opaque, hwaddr offset,
@@ -556,7 +558,8 @@ static uint32_t gic_cpu_read(GICState *s, int cpu, int offset)
     case 0x18: /* Highest Pending Interrupt */
         return s->current_pending[cpu];
     default:
-        hw_error("gic_cpu_read: Bad offset %x\n", (int)offset);
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "gic_cpu_read: Bad offset %x\n", (int)offset);
         return 0;
     }
 }
@@ -577,7 +580,8 @@ static void gic_cpu_write(GICState *s, int cpu, int offset, uint32_t value)
     case 0x10: /* End Of Interrupt */
         return gic_complete_irq(s, cpu, value & 0x3ff);
     default:
-        hw_error("gic_cpu_write: Bad offset %x\n", (int)offset);
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "gic_cpu_write: Bad offset %x\n", (int)offset);
         return;
     }
     gic_update(s);
-- 
1.7.9.5

  parent reply	other threads:[~2012-10-25 12:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 12:57 [Qemu-devel] [PATCH 00/12] use LOG_GUEST_ERROR in more ARM devices Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 01/12] hw/pl050: Use LOG_GUEST_ERROR Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 02/12] hw/pl061: " Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 03/12] hw/pl080: Use LOG_GUEST_ERROR and LOG_UNIMP Peter Maydell
2012-10-25 13:19   ` malc
2012-10-25 13:23     ` Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 04/12] hw/pl110: Use LOG_GUEST_ERROR rather than hw_error() Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 05/12] hw/pl190: Use LOG_UNIMP " Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 06/12] hw/arm11mpcore: Use LOG_GUEST_ERROR " Peter Maydell
2012-10-25 12:57 ` Peter Maydell [this message]
2012-10-25 12:57 ` [Qemu-devel] [PATCH 08/12] hw/arm_timer: Use LOG_GUEST_ERROR and LOG_UNIMP Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 09/12] hw/armv7m_nvic: " Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 10/12] hw/arm_sysctl: Use LOG_GUEST_ERROR Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 11/12] hw/arm_l2x0: " Peter Maydell
2012-10-25 12:57 ` [Qemu-devel] [PATCH 12/12] hw/versatile_i2c: " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351169867-5466-8-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).