From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
Meador Inge <meadori@codesourcery.com>,
Paul Brook <paul@codesourcery.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/3] target-m68k/m68k-semi: don't ignore get/put_user failure
Date: Mon, 29 Oct 2012 12:05:08 +0000 [thread overview]
Message-ID: <1351512311-19106-1-git-send-email-peter.maydell@linaro.org> (raw)
This patch series cleans up the m68k semihosting support to not
ignore failure of get_user and put_user when reading semihosting
arguments and writing return values (compare f296c0d1 which did
something similar for ARM semihosting). The main motivation for
this patch is to shut up clang's complaints about 'expression
result unused'. Tested with a simple m68k hello world semihosting
binary created with the CodeSourcery coldfire toolchain:
~/freescale-coldfire-2011.09/bin/m68k-elf-gcc -T m5206ec3-ram-hosted.ld -o /tmp/hello /tmp/hello.c -lc -lcs3hosted
./m68k-softmmu/qemu-system-m68k -semihosting -M dummy -display none -kernel /tmp/hello
Meador's patch is already in qemu-trivial but I include it
here as it is a dependency.
Meador Inge (1):
m68k: Return semihosting errno values correctly
Peter Maydell (2):
target-m68k/m68k-semi: Handle get_user failure
target-m68k/m68k-semi.c: Log when put_user for returning values fails
target-m68k/m68k-semi.c | 191 +++++++++++++++++++++++++++++++-----------------
1 file changed, 124 insertions(+), 67 deletions(-)
--
1.7.11.4
next reply other threads:[~2012-10-29 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 12:05 Peter Maydell [this message]
2012-10-29 12:05 ` [Qemu-devel] [PATCH 1/3] m68k: Return semihosting errno values correctly Peter Maydell
2012-10-29 12:05 ` [Qemu-devel] [PATCH 2/3] target-m68k/m68k-semi: Handle get_user failure Peter Maydell
2012-10-29 12:05 ` [Qemu-devel] [PATCH 3/3] target-m68k/m68k-semi.c: Log when put_user for returning values fails Peter Maydell
2012-11-03 12:51 ` [Qemu-devel] [PATCH 0/3] target-m68k/m68k-semi: don't ignore get/put_user failure Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351512311-19106-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=blauwirbel@gmail.com \
--cc=meadori@codesourcery.com \
--cc=patches@linaro.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).